From: Joe Perches <joe@perches.com>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
linux-kernel@vger.kernel.org,
Christian Lamparter <chunkeey@web.de>,
Johannes Berg <johannes@sipsolutions.net>,
"John W. Linville" <linville@tuxdriver.com>,
Greg KH <greg@kroah.com>, Stephen Chen <Stephen.Chen@atheros.com>,
Zhifeng Cai <zhifeng.cai@atheros.com>,
Cliff Holden <Cliff.Holden@atheros.com>,
Christoph Hellwig <hch@infradead.org>,
Len Widra <Len.Widra@atheros.com>
Subject: Re: Initial work for ar9271
Date: Tue, 25 Aug 2009 21:31:50 -0700 [thread overview]
Message-ID: <1251261111.3463.15.camel@Joe-Laptop.home> (raw)
In-Reply-To: <43e72e890908252103j2332d8eat9e18fecb20a1fe58@mail.gmail.com>
On Tue, 2009-08-25 at 21:03 -0700, Luis R. Rodriguez wrote:
> If you'd like to work on the
> driver I welcome patches:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/ar9271.git
I think this style ugly because it's non kernel standard.
int func(args)
{
do {
[ linear code ...]
if (err) {
errorcode = ;
break;
}
[ more linear code ...]
} while (0);
if (errorcode) {
handle()...
return some_err;
}
return 0;
}
It's a bit too much like a try/throw/catch block.
Are patches accepted to convert it to the more
commonly used kernel style using gotos?
next prev parent reply other threads:[~2009-08-26 4:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-26 4:03 Luis R. Rodriguez
2009-08-26 4:24 ` Greg KH
2009-08-26 4:31 ` Joe Perches [this message]
2009-08-26 4:34 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251261111.3463.15.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=Cliff.Holden@atheros.com \
--cc=Len.Widra@atheros.com \
--cc=Stephen.Chen@atheros.com \
--cc=chunkeey@web.de \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=zhifeng.cai@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®