From: Suresh Siddha <suresh.b.siddha@intel.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Cyrill Gorcunov <gorcunov@openvz.org>
Subject: Re: [PATCH] x86: use hard_smp_processor_id to get apic id in identify_cpu -v2
Date: Wed, 26 Aug 2009 15:24:15 -0700 [thread overview]
Message-ID: <1251325455.2787.61.camel@sbs-t61.sc.intel.com> (raw)
In-Reply-To: <4A9587FE.20503@kernel.org>
On Wed, 2009-08-26 at 12:07 -0700, Yinghai Lu wrote:
> Suresh Siddha wrote:
> >
> > In short, on all the platforms we want to use initial apic id for apicid
> > and phys_proc_id. And only on the required platforms like x445, vsmp,
> > some AMD platforms, we can have their own mechanisms.
> >
> >> 3. for vsmp, and x445, do you want to have c->apicid to have real apic id or the same as initial apic_id?
> >
> > On these platforms, c->apicid should be based on their real apic id.
> >
> >> this patch is trying to make c->apicid to have real apic_id.
> >
> > Can you please modify the patch so that we can have exceptions for
> > needed platforms only?
> >
>
> please check this one
>
> [PATCH] x86: use hard_smp_processor_id to get apic id for amd k8 cpus
>
> otherwise, system with apci id lifting will have wrong apicid in
> /proc/cpuinfo
>
> and use that in srat_detect_node
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>
Looks better.
next prev parent reply other threads:[~2009-08-26 22:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-25 7:25 [PATCH] x86: use hard_smp_processor_id to get apic id in identify_cpu Yinghai Lu
2009-08-25 19:51 ` [PATCH] x86: use c->apicid directly in srat_detect_node Yinghai Lu
2009-08-25 22:06 ` [PATCH] x86: use hard_smp_processor_id to get apic id in identify_cpu -v2 Yinghai Lu
2009-08-25 22:53 ` Suresh Siddha
2009-08-26 1:14 ` Yinghai Lu
2009-08-26 17:49 ` Suresh Siddha
2009-08-26 19:07 ` Yinghai Lu
2009-08-26 22:24 ` Suresh Siddha [this message]
2009-08-29 20:17 ` [PATCH] x86: use hard_smp_processor_id to get apic id for amd k8 cpus Yinghai Lu
2009-09-04 7:59 ` [tip:x86/cpu] x86: Use hard_smp_processor_id() to get apic id for AMD K8 cpus tip-bot for Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251325455.2787.61.camel@sbs-t61.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=gorcunov@openvz.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®