mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 3/4] perf tools: Unify swapper tasks naming
Date: Mon, 31 Aug 2009 06:45:20 +0200	[thread overview]
Message-ID: <1251693921-6579-3-git-send-email-fweisbec@gmail.com> (raw)
In-Reply-To: <1251682323-10395-1-git-send-email-fweisbec@gmail.com>

In perf tools, we hardcode the pid 0 cmdline resolving to "idle"
because the init task is not included in the COMM events.

But the idle tasks secondary cpus are resolved into their "init"
name through the COMM events.
We have then such strange result in perf report (ditto with trace):

    19.66%       init    [kernel]          [k] acpi_idle_enter_c1
    17.32%       [idle]  [kernel]          [k] acpi_idle_enter_c1

It's then better to unify the swapper tasks into a single init name.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/thread.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c
index 3acd37f..7635928 100644
--- a/tools/perf/util/thread.c
+++ b/tools/perf/util/thread.c
@@ -85,7 +85,7 @@ register_idle_thread(struct rb_root *threads, struct thread **last_match)
 {
 	struct thread *thread = threads__findnew(0, threads, last_match);
 
-	if (!thread || thread__set_comm(thread, "[idle]")) {
+	if (!thread || thread__set_comm(thread, "[init]")) {
 		fprintf(stderr, "problem inserting idle task.\n");
 		exit(-1);
 	}
-- 
1.6.2.3


  parent reply	other threads:[~2009-08-31  4:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-31  1:32 [PATCH] perf tools: Add missing parameters documentation Frederic Weisbecker
2009-08-31  4:45 ` [PATCH 1/4] perf tools: Librarize idle thread registration Frederic Weisbecker
2009-08-31  8:37   ` [tip:perfcounters/core] " tip-bot for Frederic Weisbecker
2009-08-31  4:45 ` [PATCH 2/4] perf tools: Resolve idle thread cmdline for perf trace Frederic Weisbecker
2009-08-31  8:37   ` [tip:perfcounters/core] " tip-bot for Frederic Weisbecker
2009-08-31  4:45 ` Frederic Weisbecker [this message]
2009-08-31  4:52   ` [PATCH 3/4] perf tools: Unify swapper tasks naming Frederic Weisbecker
2009-08-31  8:37   ` [tip:perfcounters/core] " tip-bot for Frederic Weisbecker
2009-08-31  4:45 ` [PATCH 4/4] perf tools: Complete support for dynamic strings Frederic Weisbecker
2009-08-31  8:11   ` Ingo Molnar
2009-08-31 16:59     ` Frederic Weisbecker
2009-09-03 16:13       ` Ingo Molnar
2009-08-31  8:37   ` [tip:perfcounters/core] " tip-bot for Frederic Weisbecker
2009-08-31  8:37 ` [tip:perfcounters/core] perf tools: Add missing parameters documentation tip-bot for Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1251693921-6579-3-git-send-email-fweisbec@gmail.com \
    --to=fweisbec@gmail.com \
    --cc=acme@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome