From: Zhang Rui <rui.zhang@intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Len Brown <lenb@kernel.org>,
linux-acpi <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>, Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH V5 0/2] Ambient Light Sensor support
Date: Tue, 01 Sep 2009 14:53:02 +0800 [thread overview]
Message-ID: <1251787982.3483.201.camel@rzhang-dt> (raw)
In-Reply-To: <1251787667.3483.197.camel@rzhang-dt>
On Tue, 2009-09-01 at 14:47 +0800, Zhang Rui wrote:
> On Tue, 2009-09-01 at 14:28 +0800, Dmitry Torokhov wrote:
> > On Mon, Aug 31, 2009 at 01:04:35PM -0400, Len Brown wrote:
> > > I put this in the acpi test tree, with the expectation
> > > that it will have at least one minor revision update
> > > before going upstream.
> > >
> > > thanks,
> > > Len Brown, Intel Open Source Technology Center
> > >
> >
> > Breaks build here...
> >
> that's weird.
> I didn't encounter this problem in my test.
>
PREFIX is defined in include/acpi/acpi_bus.h,
which has already been included in this driver.
I got this after applying your patch,
CC drivers/acpi/als.o
drivers/acpi/als.c:46:1: warning: "PREFIX" redefined
In file included from drivers/acpi/als.c:30:
include/acpi/acpi_bus.h:33:1: warning: this is the location of the
previous definition
rui
next prev parent reply other threads:[~2009-09-01 6:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 8:07 Zhang Rui
2009-08-31 17:04 ` Len Brown
2009-09-01 6:28 ` Dmitry Torokhov
2009-09-01 6:47 ` Zhang Rui
2009-09-01 6:53 ` Zhang Rui [this message]
2009-09-01 7:00 ` Dmitry Torokhov
2009-09-01 7:11 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251787982.3483.201.camel@rzhang-dt \
--to=rui.zhang@intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=greg@kroah.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®