Re: [PATCH V6 2/2] introduce ACPI ALS device driver

[Zhang Rui <rui.zhang@intel.com>]

On Tue, 2009-09-01 at 16:13 +0800, Pavel Machek wrote:
> Hi!
> 
> > ACPI spec defines ACPI Ambient Light Sensor device (hid ACPI0008),
> > which provides a standard interface by which the OS may query properties
> > of the ambient light environment the system is currently operating in,
> > as well as the ability to detect meaningful changes in these values when
> > the environment changes.
> 
> > +struct acpi_als {
> > +	struct acpi_device *device;
> > +	struct als_device *als_sys;
> > +	int illuminance;
> > +	int chromaticity;
> > +	int temperature;
> > +	int polling;
> > +	int count;
> > +	struct als_mapping *mappings;
> > +};
> 
> chromaticity is write-only variable.

>  I believe you can drop it and
> associted code.
> 
> temperature ditto. Drop from this version?
> 
> polling ditto. Drop from this version?
> 
color temperature, chromaticity and polling are three optional features
defined in the ACPI spec, which are not supported yet in the ACPI ALS
driver right now.

I think it's okay to add the code first and then generate some
incremental patches to enable these features once we found such kind of
platforms.

thanks,
rui


> Thanks,
> 									Pavel