From: Eric Paris <eparis@redhat.com>
To: unlisted-recipients:; (no To-header on input)
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
netdev@vger.kernel.org, davem@davemloft.net,
viro@zeniv.linux.org.uk, alan@linux.intel.com, hch@infradead.org
Subject: Re: [PATCH 1/9] task_struct: add PF_NONOTIFY for fanotify to use
Date: Thu, 03 Sep 2009 16:25:49 -0400 [thread overview]
Message-ID: <1252009549.2425.42.camel@dhcp231-106.rdu.redhat.com> (raw)
In-Reply-To: <20090828223626.GA8283@ioremap.net>
> On Fri, Aug 28, 2009 at 02:55:42PM -0400, Eric Paris (eparis@redhat.com) wrote:
> > Since fanotify opens file descriptors inside the kernel for it's listeners
> > it needs a way to make sure that 2 fanotify listeners, both which listen to
> > open events do not continuously see each others open events (and get into a
> > livelock reporting on each other's activity). This fix is to create a new
> > tast_struct flags called PF_NONOTIFY. If this flag is set in a task no
> > fanotify events will be generated for that task. fanotify will set the
> > flag before and open call and will clear it immediately after.
So this patch isn't actually needed, I thought the fsnotify_open() call
was deeper than it is. I'm going to drop this particular patch.
Can I take silence on the list as a lack of disagreement? I'd like to
start putting these into linux-next starting tomorrow. Obviously I'd
like to see the networking definitions approved and taken by davem, I'd
like to see the FMODE_ change approved and taken by viro, but if you two
would like me to push it directly I'd be happy to.
Davem, maybe you'd rather my af_fanotify was somewhere inside net/
instead of in fs/notify/fanotify? I'd love to get some review here, but
noone onlist is excited enough to step up. (I have numerous people who
have privately claimed they intend to use this stuff, so i promise it
won't be dead code.)
I'm ready to start committing and adding features, anyone telling me no?
-Eric
prev parent reply other threads:[~2009-09-03 20:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-28 18:55 Eric Paris
2009-08-28 18:55 ` [PATCH 2/9] vfs: introduce FMODE_NONOTIFY Eric Paris
2009-08-28 18:55 ` [PATCH 3/9] networking/fanotify: declare fanotify socket numbers Eric Paris
2009-08-28 18:56 ` [PATCH 4/9] fanotify: fscking all notification system Eric Paris
2009-08-28 18:56 ` [PATCH 5/9] fanotify:drop notification if they exist in the outgoing queue Eric Paris
2009-08-28 18:56 ` [PATCH 6/9] fanotify: merge notification events with different masks Eric Paris
2009-08-28 18:56 ` [PATCH 7/9] fanotify: userspace socket Eric Paris
2009-08-28 18:56 ` [PATCH 8/9] fanotify: userspace can add and remove fsnotify inode marks Eric Paris
2009-08-28 18:56 ` [PATCH 9/9] fanotify: send events to userspace over socket reads Eric Paris
2009-08-28 22:36 ` [PATCH 1/9] task_struct: add PF_NONOTIFY for fanotify to use Evgeniy Polyakov
2009-08-28 22:39 ` Eric Paris
2009-08-28 22:50 ` Evgeniy Polyakov
2009-09-03 20:25 ` Eric Paris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252009549.2425.42.camel@dhcp231-106.rdu.redhat.com \
--to=eparis@redhat.com \
--cc=alan@linux.intel.com \
--cc=davem@davemloft.net \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®