From: Joerg Roedel <joerg.roedel@amd.com>
To: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Cc: Joerg Roedel <joerg.roedel@amd.com>, stable@kernel.org
Subject: [PATCH 4/4] x86/amd-iommu: fix broken check in amd_iommu_flush_all_devices
Date: Fri, 4 Sep 2009 11:47:27 +0200 [thread overview]
Message-ID: <1252057647-32322-5-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1252057647-32322-1-git-send-email-joerg.roedel@amd.com>
The amd_iommu_pd_table is indexed by protection domain
number and not by device id. So this check is broken and
must be removed.
Cc: stable@kernel.org
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
arch/x86/kernel/amd_iommu.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
index 3e62d78..009d722 100644
--- a/arch/x86/kernel/amd_iommu.c
+++ b/arch/x86/kernel/amd_iommu.c
@@ -479,8 +479,6 @@ void amd_iommu_flush_all_devices(void)
int i;
for (i = 0; i <= amd_iommu_last_bdf; ++i) {
- if (amd_iommu_pd_table[i] == NULL)
- continue;
iommu = amd_iommu_rlookup_table[i];
if (!iommu)
--
1.6.3.3
prev parent reply other threads:[~2009-09-04 9:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-04 9:47 [PATCH 0/4] Fixes and Cleanups (AMD-Vi) Joerg Roedel
2009-09-04 9:47 ` [PATCH 1/4] x86/amd-iommu: Remove some merge helper code Joerg Roedel
2009-09-04 9:47 ` [PATCH 2/4] x86/amd-iommu: replace "AMD IOMMU" by "AMD-Vi" Joerg Roedel
2009-09-04 9:47 ` [PATCH 3/4] x86/amd-iommu: Remove redundant 'IOMMU' string Joerg Roedel
2009-09-04 9:47 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252057647-32322-5-git-send-email-joerg.roedel@amd.com \
--to=joerg.roedel@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®