From: Eric Paris <eparis@redhat.com>
To: Maciej Rutecki <maciej.rutecki@gmail.com>
Cc: Oliver Neukum <oliver@neukum.org>, Greg KH <greg@kroah.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-usb@vger.kernel.org, ebiederm@aristanetworks.com
Subject: Re: [2.6.31-rc8] Problem with detect USB devices
Date: Fri, 04 Sep 2009 14:35:13 -0400 [thread overview]
Message-ID: <1252089313.5254.0.camel@dhcp231-106.rdu.redhat.com> (raw)
In-Reply-To: <8db1092f0909041130p2733f7ebs5ee8211c48bab861@mail.gmail.com>
On Fri, 2009-09-04 at 20:30 +0200, Maciej Rutecki wrote:
> 2009/9/4 Maciej Rutecki <maciej.rutecki@gmail.com>:
> > 2009/9/4 Oliver Neukum <oliver@neukum.org>:
> >
> >>
> >> Maciej,
> >>
> >> can you run a git bisection?
> >>
>
>
> 0db501bd0610ee0c0aca84d927f90bcccd09e2bd is first bad commit
> commit 0db501bd0610ee0c0aca84d927f90bcccd09e2bd
> Author: Eric W. Biederman <ebiederm@xmission.com>
> Date: Thu Aug 27 03:20:04 2009 -0700
>
> inotify: Ensure we alwasy write the terminating NULL.
>
> Before the rewrite copy_event_to_user always wrote a terqminating '\0'
> byte to user space after the filename. Since the rewrite that
> terminating byte was skipped if your filename is exactly a multiple of
> event_size. Ouch!
>
> So add one byte to name_size before we round up and use clear_user to
> set userspace to zero like /dev/zero does instead of copying the
> strange nul_inotify_event. I can't quite convince myself len_to_zero
> will never exceed 16 and even if it doesn't clear_user should be more
> efficient and a more accurate reflection of what the code is trying to
> do.
>
> Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
> Signed-off-by: Eric Paris <eparis@redhat.com>
>
> :040000 040000 ae8bc8bebfd205cde1f7b7689f60a2ada08b1e24
> 7be919a71e3e27510ec38f95664a5e770ce82ad8 M fs
>
> Unfortunately I cannot revert it (to make sure):
> root@gumis:/usr/src/git/linux-2.6# git revert
> 0db501bd0610ee0c0aca84d927f90bcccd09e2bd
> Automatic revert failed. After resolving the conflicts,
> mark the corrected paths with 'git add <paths>' or 'git rm <paths>'
> and commit the result.
Update to Linus's newest git tree. It has a fix for this problem.
Sorry for all the trouble.
-Eric
next prev parent reply other threads:[~2009-09-04 18:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 13:29 Maciej Rutecki
2009-09-02 13:42 ` Oliver Neukum
2009-09-02 14:15 ` Maciej Rutecki
2009-09-03 7:07 ` Oliver Neukum
2009-09-03 16:05 ` Greg KH
2009-09-04 10:23 ` Oliver Neukum
2009-09-04 14:10 ` Maciej Rutecki
2009-09-04 18:30 ` Maciej Rutecki
2009-09-04 18:35 ` Eric Paris [this message]
2009-09-04 20:16 ` Maciej Rutecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252089313.5254.0.camel@dhcp231-106.rdu.redhat.com \
--to=eparis@redhat.com \
--cc=ebiederm@aristanetworks.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=oliver@neukum.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®