From: Catalin Marinas <catalin.marinas@arm.com>
To: "Luis R. Rodriguez" <lrodriguez@Atheros.com>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"penberg@cs.helsinki.fi" <penberg@cs.helsinki.fi>,
"mcgrof@gmail.com" <mcgrof@gmail.com>
Subject: Re: [PATCH v2 2/5] kmemleak: add clear command support
Date: Fri, 04 Sep 2009 23:28:47 +0100 [thread overview]
Message-ID: <1252103327.21380.6.camel@pc1117.cambridge.arm.com> (raw)
In-Reply-To: <20090904202653.GE4949@mosca>
On Fri, 2009-09-04 at 13:26 -0700, Luis R. Rodriguez wrote:
> On Thu, Sep 03, 2009 at 09:52:11AM -0700, Catalin Marinas wrote:
> > On Thu, 2009-09-03 at 01:35 -0400, Luis R. Rodriguez wrote:
> > > In an ideal world your kmemleak output will be small,
> > > when its not you can use the clear command to ingore previously
> > > annotated kmemleak objects. We do this by painting them black.
> >
> > Making the objects "black" means that they are completely ignored by
> > kmemleak and they are assumed not to contain any valid references.
> > Therefore they won't be scanned and many of the newly allocated objects
> > would be false positives.
>
> Got it, BTW can you elaborate as to why painting objects black would
> create false positives for newly allocated objects? I fail to understand
> why.
Black objects are not scanned by kmemleak. Making valid objects black as
per your patch, they may (actually quite likely) contain pointers to
newly allocated objects. Since they won't be scanned, the newly
allocated objects are reported as unreferenced as no pointers to them
were found during scanning.
--
Catalin
next prev parent reply other threads:[~2009-09-04 22:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-03 5:35 [PATCH v2 0/5] kmemleak: few small cleanups and " Luis R. Rodriguez
2009-09-03 5:35 ` [PATCH v2 1/5] kmemleak: use bool for true/false questions Luis R. Rodriguez
2009-09-03 5:35 ` [PATCH v2 2/5] kmemleak: add clear command support Luis R. Rodriguez
2009-09-03 16:52 ` Catalin Marinas
2009-09-04 20:26 ` Luis R. Rodriguez
2009-09-04 22:28 ` Catalin Marinas [this message]
2009-09-03 5:35 ` [PATCH v2 3/5] kmemleak: move common painting code together Luis R. Rodriguez
2009-09-03 5:35 ` [PATCH v2 4/5] kmemleak: fix sparse warning over overshadowed flags Luis R. Rodriguez
2009-09-03 16:55 ` Catalin Marinas
2009-09-03 18:05 ` Luis R. Rodriguez
2009-09-03 5:35 ` [PATCH v2 5/5] kmemleak: fix sparse warning for static declarations Luis R. Rodriguez
2009-09-03 6:01 ` [PATCH v2 0/5] kmemleak: few small cleanups and clear command support Pekka Enberg
2009-09-03 8:30 ` Catalin Marinas
2009-09-04 19:57 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252103327.21380.6.camel@pc1117.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrodriguez@Atheros.com \
--cc=mcgrof@gmail.com \
--cc=penberg@cs.helsinki.fi \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®