From: Matt Mackall <mpm@selenic.com>
To: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tmpfs: depend on shmem
Date: Tue, 08 Sep 2009 17:51:19 -0500 [thread overview]
Message-ID: <1252450279.7145.82.camel@calx> (raw)
In-Reply-To: <Pine.LNX.4.64.0909082111400.11481@sister.anvils>
On Tue, 2009-09-08 at 21:25 +0100, Hugh Dickins wrote:
> CONFIG_SHMEM off gives you (ramfs masquerading as) tmpfs, even when
> CONFIG_TMPFS is off: that's a little anomalous, and I'd intended to
> make more sense of it by removing CONFIG_TMPFS altogether, always
> enabling its code when CONFIG_SHMEM; but so many defconfigs have
> CONFIG_SHMEM on CONFIG_TMPFS off that we'd better leave that as is.
>
> But there is no point in asking for CONFIG_TMPFS if CONFIG_SHMEM is
> off: make TMPFS depend on SHMEM, which also prevents TMPFS_POSIX_ACL
> shmem_acl.o being pointlessly built into the kernel when SHMEM is off.
Fair enough.
> And a selfish change, to prevent the world from being rebuilt when I
> switch between CONFIG_SHMEM on and off: the only CONFIG_SHMEM in the
> header files is mm.h shmem_lock() - give that a shmem.c stub instead.
Might as well, on the principle of one less ifdef.
> Signed-off-by: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Acked-by: Matt Mackall <mpm@selenic.com>
--
http://selenic.com : development and support for Mercurial and Linux
prev parent reply other threads:[~2009-09-08 22:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-08 20:25 Hugh Dickins
2009-09-08 22:51 ` Matt Mackall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252450279.7145.82.camel@calx \
--to=mpm@selenic.com \
--cc=akpm@linux-foundation.org \
--cc=hugh.dickins@tiscali.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®