From: David Daney <ddaney@caviumnetworks.com>
To: torvalds@linux-foundation.org, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org,
David Daney <ddaney@caviumnetworks.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org
Subject: [PATCH 02/10] x86: Convert BUG() to use unreachable()
Date: Thu, 10 Sep 2009 16:56:43 -0700 [thread overview]
Message-ID: <1252627011-2933-2-git-send-email-ddaney@caviumnetworks.com> (raw)
In-Reply-To: <4AA991C1.1050800@caviumnetworks.com>
Use the new unreachable() macro instead of for(;;);. When
allyesconfig is built with a GCC-4.5 snapshot on i686 the size of the
text segment is reduced by 3987 bytes (from 6827019 to 6823032).
Signed-off-by: David Daney <ddaney@caviumnetworks.com>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: Ingo Molnar <mingo@redhat.com>
CC: "H. Peter Anvin" <hpa@zytor.com>
CC: x86@kernel.org
---
arch/x86/include/asm/bug.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/bug.h b/arch/x86/include/asm/bug.h
index d9cf1cd..f654d1b 100644
--- a/arch/x86/include/asm/bug.h
+++ b/arch/x86/include/asm/bug.h
@@ -22,14 +22,14 @@ do { \
".popsection" \
: : "i" (__FILE__), "i" (__LINE__), \
"i" (sizeof(struct bug_entry))); \
- for (;;) ; \
+ unreachable(); \
} while (0)
#else
#define BUG() \
do { \
asm volatile("ud2"); \
- for (;;) ; \
+ unreachable(); \
} while (0)
#endif
--
1.6.2.5
next prev parent reply other threads:[~2009-09-10 23:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4AA991C1.1050800@caviumnetworks.com>
2009-09-10 23:56 ` [PATCH 01/10] Add support for GCC-4.5's __builtin_unreachable() to compiler.h David Daney
2009-09-11 0:14 ` Richard Henderson
2009-09-11 14:32 ` Michael Buesch
2009-09-11 15:58 ` David Daney
2009-09-12 7:22 ` Geert Uytterhoeven
2009-09-14 15:40 ` David Daney
2009-09-10 23:56 ` David Daney [this message]
2009-09-11 0:56 ` [PATCH 02/10] x86: Convert BUG() to use unreachable() H. Peter Anvin
2009-09-11 1:09 ` Roland McGrath
2009-09-11 1:13 ` Linus Torvalds
2009-09-11 1:33 ` H. Peter Anvin
2009-09-11 1:37 ` Roland McGrath
2009-09-11 1:42 ` H. Peter Anvin
2009-09-11 6:07 ` Ingo Molnar
2009-09-11 15:55 ` David Daney
2009-09-13 20:12 ` H. Peter Anvin
2009-09-10 23:56 ` [PATCH 03/10] MIPS: " David Daney
2009-09-10 23:56 ` [PATCH 04/10] s390: " David Daney
2009-09-11 12:18 ` Martin Schwidefsky
2009-09-10 23:56 ` [PATCH 05/10] mn10300: " David Daney
2009-09-10 23:56 ` [PATCH 06/10] parisc: " David Daney
2009-09-28 3:20 ` Kyle McMartin
2009-09-10 23:56 ` [PATCH 07/10] powerpc: " David Daney
2009-09-10 23:56 ` [PATCH 08/10] alpha: " David Daney
2009-09-10 23:56 ` [PATCH 09/10] avr32: " David Daney
2009-09-11 7:31 ` Haavard Skinnemoen
2009-09-10 23:56 ` [PATCH 10/10] blackfin: " David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252627011-2933-2-git-send-email-ddaney@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®