From: Steven Rostedt <rostedt@goodmis.org>
To: jolsa@redhat.com
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 3/3] [PATCHv3 3/3] tracing - trace parser support for set_graph_function set_ftrace_filter set_ftrace_notrace
Date: Fri, 11 Sep 2009 15:20:10 -0400 [thread overview]
Message-ID: <1252696810.18996.733.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1252682969-3366-4-git-send-email-jolsa@redhat.com>
Nit - fix your scripts again. The subject duplicates the [PATCHv3 3/3].
On Fri, 2009-09-11 at 17:29 +0200, jolsa@redhat.com wrote:
> Fixed minor in set_graph_function display - g_show function.
> @@ -2499,7 +2456,7 @@ static int g_show(struct seq_file *m, void *v)
> return 0;
> }
>
> - seq_printf(m, "%pf\n", v);
> + seq_printf(m, "%p\n", (void *) *ptr);
>
> return 0;
> }
I changed this, because it has a bug itself. You just changed the way
set_graph_function works.
It use to do:
# echo sys_open > set_graph_function
# cat set_graph_function
sys_open
After this change, it does
# echo sys_open > set_graph_function
# cat set_graph_function
ffffffff811020d0
Which is not very helpful.
But, you did catch a bug. Another clean up patch, made it from *ptr to
v, which is wrong. Half that change is correct ;-)
Thus I modified this patch with the following change:
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 7d68163..8b23d56 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -2456,7 +2456,7 @@ static int g_show(struct seq_file *m, void *v)
return 0;
}
- seq_printf(m, "%p\n", (void *) *ptr);
+ seq_printf(m, "%pf\n", (void *)*ptr);
return 0;
}
-- Steve
next prev parent reply other threads:[~2009-09-11 19:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 15:29 [PATCHv3 0/3] tracing - adding common method for reading/parsing user input jolsa
2009-09-11 15:29 ` [PATCHv3 1/3] [PATCHv3 1/3] tracing - trace parser definition, parsing function jolsa
2009-09-12 7:54 ` [tip:tracing/core] tracing: create generic trace parser tip-bot for jolsa@redhat.com
2009-09-11 15:29 ` [PATCHv3 2/3] [PATCHv3 2/3] tracing - trace parser support for set_event jolsa
2009-09-12 7:54 ` [tip:tracing/core] tracing: " tip-bot for jolsa@redhat.com
2009-09-11 15:29 ` [PATCHv3 3/3] [PATCHv3 3/3] tracing - trace parser support for set_graph_function set_ftrace_filter set_ftrace_notrace jolsa
2009-09-11 19:20 ` Steven Rostedt [this message]
2009-09-14 6:33 ` Jiri Olsa
2009-09-12 7:55 ` [tip:tracing/core] tracing: trace parser support for function and graph tip-bot for jolsa@redhat.com
2009-09-11 15:32 ` [PATCHv3 0/3] tracing - adding common method for reading/parsing user input Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252696810.18996.733.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®