From: Steven Rostedt <rostedt@goodmis.org>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] ftrace: document basic ftracer/ftracer graph needs
Date: Mon, 14 Sep 2009 17:20:59 -0400 [thread overview]
Message-ID: <1252963259.20020.58.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <8bd0f97a0909141401y56961a77nfb2b78b43e8b0426@mail.gmail.com>
On Mon, 2009-09-14 at 17:01 -0400, Mike Frysinger wrote:
> On Mon, Sep 14, 2009 at 16:53, Steven Rostedt wrote:
> > On Mon, 2009-09-14 at 16:21 -0400, Mike Frysinger wrote:
> >> On Mon, Sep 14, 2009 at 15:48, Steven Rostedt wrote:
> >> > On Sat, 2009-06-13 at 23:05 -0400, Mike Frysinger wrote:
> >> >> diff --git a/Documentation/trace/ftrace.txt b/Documentation/trace/ftrace.txt
> >> >> index fd9a3e6..95a39fb 100644
> >> >> --- a/Documentation/trace/ftrace.txt
> >> >> +++ b/Documentation/trace/ftrace.txt
> >> >> @@ -27,6 +27,12 @@ disabled, and more (ftrace allows for tracer plugins, which
> >> >> means that the list of tracers can always grow).
> >> >>
> >> >>
> >> >> +Implementation Details
> >> >> +----------------------
> >> >> +
> >> >> +See ftrace-implementation.txt for details for arch porters and such.
> >> >
> >> > Might want to specify that this is for the function tracer.
> >>
> >> well, all of ftrace.txt says "function tracer", so if/when someone
> >> cleans that up, this will get fixed in the process.
> >
> > Well things do need to be clean up, the original code had the function
> > tracer called ftrace, which it no longer does. Why add more incorrect
> > documentation just to match the previous incorrect documentation?
>
> if the filename is updated, do i really need to duplicate it ?
>
> See function-tracer-design.txt for details for arch porters and such.
>
> if people add other design/porting info, this can be a simple list and
> the filename itself can imply the details contained within ...
Fine, then rename it to ftrace-design.txt (this corresponds to other
docs in Documentation, like lockdep-design.txt and rt-mutex-design.txt)
Then in the file, start it with "Function tracer implementation" or
something similar.
next prev parent reply other threads:[~2009-09-14 21:20 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 8:48 [PATCH 1/2] ftrace.txt: fix typo in function grapher name Mike Frysinger
2009-06-10 8:48 ` [PATCH 2/2] ftrace: document basic ftracer/ftracer graph needs Mike Frysinger
2009-06-10 17:04 ` Steven Rostedt
2009-06-10 18:31 ` Mike Frysinger
2009-06-10 18:45 ` Steven Rostedt
2009-06-10 19:07 ` Mike Frysinger
2009-06-10 19:11 ` Steven Rostedt
2009-06-10 19:19 ` Mike Frysinger
2009-06-10 19:34 ` Steven Rostedt
2009-06-10 19:45 ` Mike Frysinger
2009-06-10 18:56 ` Steven Rostedt
2009-06-10 20:52 ` [PATCH 2/2 v2] " Mike Frysinger
2009-06-12 8:10 ` Mike Frysinger
2009-06-13 22:24 ` Frederic Weisbecker
2009-06-14 0:21 ` [PATCH v3] " Mike Frysinger
2009-06-14 1:24 ` Frederic Weisbecker
2009-06-14 1:52 ` Mike Frysinger
2009-06-14 2:24 ` Frederic Weisbecker
2009-06-14 3:05 ` [PATCH v4] " Mike Frysinger
2009-06-14 13:35 ` Frederic Weisbecker
2009-06-23 12:30 ` Mike Frysinger
2009-06-23 13:43 ` Ingo Molnar
2009-09-14 1:54 ` Mike Frysinger
2009-09-14 2:35 ` Steven Rostedt
2009-09-14 19:48 ` Steven Rostedt
2009-09-14 20:21 ` Mike Frysinger
2009-09-14 20:53 ` Steven Rostedt
2009-09-14 21:01 ` Mike Frysinger
2009-09-14 21:20 ` Steven Rostedt [this message]
2009-09-14 21:30 ` Mike Frysinger
2009-09-14 21:41 ` Steven Rostedt
2009-09-14 20:28 ` Frederic Weisbecker
2009-09-15 0:10 ` [PATCH v5] " Mike Frysinger
2009-09-15 1:48 ` [PATCH] [GIT PULL] " Steven Rostedt
2009-09-17 7:47 ` [tip:tracing/core] ftrace: document function and function graph implementation tip-bot for Mike Frysinger
2009-06-14 15:10 ` [PATCH 2/2 v2] ftrace: document basic ftracer/ftracer graph needs Wu Zhangjin
2009-06-14 15:45 ` Mike Frysinger
2009-06-14 16:09 ` Wu Zhangjin
2009-06-15 6:25 ` Mike Frysinger
2009-06-10 17:02 ` [PATCH 1/2] ftrace.txt: fix typo in function grapher name Steven Rostedt
2009-06-10 17:08 ` [PATCH][GIT PULL] ftrace/documentation: " Steven Rostedt
2009-06-10 22:33 ` [tip:tracing/core] " tip-bot for Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252963259.20020.58.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®