Re: [PATCHv2] tracing - support multiple pids in set_pid_ftrace file

[Steven Rostedt <rostedt@goodmis.org>]

On Tue, 2009-09-15 at 15:04 +0200, jolsa@redhat.com wrote:
> Adding the possibility to set more than 1 pid in the set_pid_ftrace file,
> thus allowing to trace more than 1 independent processes.
> 
> Usage:
> 
> sh-4.0# echo 284 > ./set_ftrace_pid 
> sh-4.0# cat ./set_ftrace_pid 
> 284
> sh-4.0# echo 1 >> ./set_ftrace_pid 
> sh-4.0# echo 0 >> ./set_ftrace_pid 
> sh-4.0# cat ./set_ftrace_pid 
> swapper tasks
> 1
> 284
> sh-4.0# echo 4 > ./set_ftrace_pid 
> sh-4.0# cat ./set_ftrace_pid 
> 4
> sh-4.0# echo > ./set_ftrace_pid 
> sh-4.0# cat ./set_ftrace_pid 
> no pid
> sh-4.0# 
> 

A quick look at the patch looks fine to me.

Li, I know you reviewed the previous version. Do you have time to look
at this one again? If so, could you, and add a "Reviewed-by" line.

Thanks,

-- Steve