From: Richard Purdie <rpurdie@rpsys.net>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] backlight: Provide two stage registration
Date: Tue, 15 Sep 2009 20:42:15 +0100 [thread overview]
Message-ID: <1253043735.30165.59.camel@dax.rpnet.com> (raw)
In-Reply-To: <20090915192730.GA8152@srcf.ucam.org>
On Tue, 2009-09-15 at 20:27 +0100, Matthew Garrett wrote:
> On Tue, Sep 15, 2009 at 08:18:42PM +0100, Richard Purdie wrote:
>
> > Could we not pass an optional pointer to a properties structure to
> > create the backlight with instead or find a better way to solve this?
>
> That'd work, but it'd involve significant refactoring of all the
> drivers - we really need to be setting max_brightness before
> device_register() is called. I suspect it'd be an even larger delta
> against mainline.
But the delta would result in more readable code rather than all that
error checking/handling. Can we see how ugly that diff turns out to be?
Cheers,
Richard
--
Richard Purdie
Intel Open Source Technology Centre
next prev parent reply other threads:[~2009-09-15 19:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 16:19 Matthew Garrett
2009-09-15 16:19 ` [PATCH 2/3] backlight: Transition drivers to new backlight API Matthew Garrett
2009-09-15 16:19 ` [PATCH 3/3] backlight: Remove old device_register and device_unregister API Matthew Garrett
2009-09-15 19:18 ` [PATCH 1/3] backlight: Provide two stage registration Richard Purdie
2009-09-15 19:27 ` Matthew Garrett
2009-09-15 19:42 ` Richard Purdie [this message]
2009-09-16 2:22 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253043735.30165.59.camel@dax.rpnet.com \
--to=rpurdie@rpsys.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®