From: Richard Purdie <rpurdie@rpsys.net>
To: Dave Hansen <dave@sr71.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [RFC][PATCH] LED driver for Intel NAS SS4200 series
Date: Tue, 15 Sep 2009 22:59:04 +0100 [thread overview]
Message-ID: <1253051944.30165.68.camel@dax.rpnet.com> (raw)
In-Reply-To: <1253051528.10449.11884.camel@nimitz>
On Tue, 2009-09-15 at 14:52 -0700, Dave Hansen wrote:
> On Tue, 2009-09-15 at 22:38 +0100, Richard Purdie wrote:
> > At a quick review this looks good. One question: These LEDs appear to be
> > attached to generic GPIOs on a southbridge that is probably in other
> > devices? If so, how do we know they're connected to LEDs? Do we need to
> > add some further check of what kind of device we're running on?
>
> Good question. I assumed that the PCI ids were a sufficient enough
> check. But, you're right, those PCI ids look like they're for all ICH7
> boards.
>
> Any suggestions on what kinds of checks we might add? This thing acts
> like a pretty generic normal PC. Do any of the other LED drivers have a
> similar problem?
Yes. In this case can we check for a set of DMI IDs? The clevo mail
driver has an example of that...
Cheers,
Richard
--
Richard Purdie
Intel Open Source Technology Centre
prev parent reply other threads:[~2009-09-15 22:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 20:38 Dave Hansen
2009-09-15 21:38 ` Richard Purdie
2009-09-15 21:52 ` Dave Hansen
2009-09-15 21:59 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253051944.30165.68.camel@dax.rpnet.com \
--to=rpurdie@rpsys.net \
--cc=arjan@infradead.org \
--cc=dave@sr71.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®