mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Atsushi Tsuji <a-tsuji@bk.jp.nec.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	fweisbec@gmail.com, "Frank Ch. Eigler" <fche@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	paulus@samba.org, systemtap@sources.redhat.com
Subject: Re: [PATCH 1/2] tracing: Fix minor bugs for __unregister_ftrace_function_probe
Date: Wed, 16 Sep 2009 09:06:38 -0400	[thread overview]
Message-ID: <1253106398.20020.192.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <4AAF6726.5090905@bk.jp.nec.com>

On Tue, 2009-09-15 at 19:06 +0900, Atsushi Tsuji wrote:
> Fix the condition of strcmp for "*".
> Also fix NULL pointer dereference when glob is NULL.
> 
> Signed-off-by: Atsushi Tsuji <a-tsuji@bk.jp.nec.com>


This is a real fix, I'll pull it in separately.

Thanks!

-- Steve

> ---
>  kernel/trace/ftrace.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 8c804e2..5ef8f59 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -2059,9 +2059,9 @@ __unregister_ftrace_function_probe(char *glob, struct ftrace_probe_ops *ops,
>  	int i, len = 0;
>  	char *search;
>  
> -	if (glob && (strcmp(glob, "*") || !strlen(glob)))
> +	if (glob && (strcmp(glob, "*") == 0 || !strlen(glob)))
>  		glob = NULL;
> -	else {
> +	else if (glob) {
>  		int not;
>  
>  		type = ftrace_setup_glob(glob, strlen(glob), &search, &not);


  reply	other threads:[~2009-09-16 13:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-15 10:06 Atsushi Tsuji
2009-09-16 13:06 ` Steven Rostedt [this message]
2009-09-17  7:48 ` [tip:tracing/core] " tip-bot for Atsushi Tsuji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1253106398.20020.192.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=a-tsuji@bk.jp.nec.com \
    --cc=fche@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®