From: Mike Frysinger <vapier@gentoo.org>
To: linux-serial@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
Sonic Zhang <sonic.zhang@analog.com>
Subject: [PATCH 3/4] serial: bfin_5xx: kgdboc should accept gdb break only when it is active
Date: Thu, 17 Sep 2009 17:52:27 -0400 [thread overview]
Message-ID: <1253224348-6996-3-git-send-email-vapier@gentoo.org> (raw)
In-Reply-To: <1253224348-6996-1-git-send-email-vapier@gentoo.org>
From: Sonic Zhang <sonic.zhang@analog.com>
If we always check for gdb breaks even when it isn't active, we get false
positives on normal code and the system panics.
URL: http://blackfin.uclinux.org/gf/tracker/5277
Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
drivers/serial/bfin_5xx.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/serial/bfin_5xx.c b/drivers/serial/bfin_5xx.c
index 663fec1..67fa057 100644
--- a/drivers/serial/bfin_5xx.c
+++ b/drivers/serial/bfin_5xx.c
@@ -233,7 +233,8 @@ static void bfin_serial_rx_chars(struct bfin_serial_port *uart)
#if defined(CONFIG_KGDB_SERIAL_CONSOLE) || \
defined(CONFIG_KGDB_SERIAL_CONSOLE_MODULE)
- if (kgdb_connected && kgdboc_port_line == uart->port.line)
+ if (kgdb_connected && kgdboc_port_line == uart->port.line
+ && kgdboc_break_enabled)
if (ch == 0x3) {/* Ctrl + C */
kgdb_breakpoint();
return;
--
1.6.5.rc1
next prev parent reply other threads:[~2009-09-17 21:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 21:52 [PATCH 1/4] serial: bfin_5xx: remove useless gpio handling with hard flow control Mike Frysinger
2009-09-17 21:52 ` [PATCH 2/4] serial: bfin_5xx: need to disable DMA TX interrupt too Mike Frysinger
2009-09-17 21:52 ` Mike Frysinger [this message]
2009-09-17 21:52 ` [PATCH 4/4] serial: bfin_5xx: pull in linux/io.h for ioremap prototypes Mike Frysinger
2010-01-19 11:13 [PATCH 1/4] serial: bfin_5xx: remove useless gpio handling with hard flow control Mike Frysinger
2010-01-19 11:13 ` [PATCH 3/4] serial: bfin_5xx: kgdboc should accept gdb break only when it is active Mike Frysinger
2010-01-26 0:11 ` Andrew Morton
2010-01-26 1:57 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253224348-6996-3-git-send-email-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sonic.zhang@analog.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®