mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tim Abbott <tabbott@ksplice.com>
To: Hirokazu Takata <takata@linux-m32r.org>
Cc: linux-m32r@ml.linux-m32r.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Sam Ravnborg <sam@ravnborg.org>, Tim Abbott <tabbott@ksplice.com>,
	Hirokazu Takata <takata@linux-m32r.org>
Subject: [PATCH v2 5/6] m32r: Move the spi_stack_top and spu_stack_top into .init.data section.
Date: Fri, 18 Sep 2009 16:32:48 -0400	[thread overview]
Message-ID: <1253305969-6948-6-git-send-email-tabbott@ksplice.com> (raw)
In-Reply-To: <1253305969-6948-1-git-send-email-tabbott@ksplice.com>

Since these get squashed into the .data output section by the m32r
linker script, it seems likely that they don't need their own input
sections.

At Hirokazu Takata's suggestion, we place these structures in
.init.data rather than just placing them in .data (since they are only
used at init time).

This patch is preparation for cleaning up the m32r architecture to use
the new macros in vmlinux.lds.h; if these sections are indeed not
needed, then we can use the RW_DATA_SECTION macro for m32r and save a
bunch of redundant code.

Signed-off-by: Tim Abbott <tabbott@ksplice.com>
Cc: Hirokazu Takata <takata@linux-m32r.org>
---
 arch/m32r/kernel/head.S        |    4 ++--
 arch/m32r/kernel/vmlinux.lds.S |    2 --
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/m32r/kernel/head.S b/arch/m32r/kernel/head.S
index 0a71944..a46652d 100644
--- a/arch/m32r/kernel/head.S
+++ b/arch/m32r/kernel/head.S
@@ -268,13 +268,13 @@ ENTRY(empty_zero_page)
 /*------------------------------------------------------------------------
  * Stack area
  */
-	.section .spi
+	.section .init.data, "aw"
 	ALIGN
 	.global spi_stack_top
 	.zero	1024
 spi_stack_top:
 
-	.section .spu
+	.section .init.data, "aw"
 	ALIGN
 	.global spu_stack_top
 	.zero	1024
diff --git a/arch/m32r/kernel/vmlinux.lds.S b/arch/m32r/kernel/vmlinux.lds.S
index a8aa4a8..aadb24e 100644
--- a/arch/m32r/kernel/vmlinux.lds.S
+++ b/arch/m32r/kernel/vmlinux.lds.S
@@ -49,8 +49,6 @@ SECTIONS
 
   /* writeable */
   .data : {			/* Data */
-	*(.spu)
-	*(.spi)
 	DATA_DATA
 	CONSTRUCTORS
 	}
-- 
1.6.3.3


  parent reply	other threads:[~2009-09-18 20:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-18 20:32 [PATCH v2 0/6] Linker script cleanup patches for m32r Tim Abbott
2009-09-18 20:32 ` [PATCH v2 1/6] m32r: make PAGE_SIZE available to assembly Tim Abbott
2009-09-18 20:32 ` [PATCH v2 2/6] m32r: Define THREAD_SIZE only once Tim Abbott
2009-09-18 20:32 ` [PATCH v2 3/6] m32r: Move GET_THREAD_INFO definition out of asm/thread_info.h Tim Abbott
2009-09-18 20:32 ` [PATCH v2 4/6] m32r: Remove unused .altinstructions and .exit.* code from linker script Tim Abbott
2009-09-18 20:32 ` Tim Abbott [this message]
2009-09-18 20:32 ` [PATCH v2 6/6] m32r: Cleanup linker script using new linker script macros Tim Abbott
2009-09-19  8:35 ` [PATCH v2 0/6] Linker script cleanup patches for m32r Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1253305969-6948-6-git-send-email-tabbott@ksplice.com \
    --to=tabbott@ksplice.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m32r@ml.linux-m32r.org \
    --cc=sam@ravnborg.org \
    --cc=takata@linux-m32r.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®