From: Suresh Siddha <suresh.b.siddha@intel.com>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mm-commits@vger.kernel.org" <mm-commits@vger.kernel.org>,
"jens.axboe@oracle.com" <jens.axboe@oracle.com>,
"mingo@elte.hu" <mingo@elte.hu>,
"nickpiggin@yahoo.com.au" <nickpiggin@yahoo.com.au>,
"rusty@rustcorp.com.au" <rusty@rustcorp.com.au>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: + generic-ipi-fix-the-race-between-generic_smp_call_function_-and-hotplug_cfd.patch added to -mm tree
Date: Fri, 18 Sep 2009 19:16:39 -0700 [thread overview]
Message-ID: <1253326599.3948.732.camel@sbs-t61.sc.intel.com> (raw)
In-Reply-To: <4AB1A652.1010000@cn.fujitsu.com>
On Wed, 2009-09-16 at 20:00 -0700, Xiao Guangrong wrote:
> How about manual check/handle pending IPI interruption in the CPU context?
> like this:
> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -173,6 +173,9 @@ static int __ref take_cpu_down(void *_param)
> struct take_cpu_down_param *param = _param;
> int err;
>
> + generic_smp_call_function_interrupt();
> + generic_smp_call_function_single_interrupt();
> +
At this place, how will you ensure that the smp_call_function initiated
by this dying cpu has reached and got serviced at its destination?
All the other cpu's have disabled interrupts in the stop machine state
by the time we come here and we can't wait.
next prev parent reply other threads:[~2009-09-19 2:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200907310030.n6V0Uqgw001644@imap1.linux-foundation.org>
[not found] ` <1252616988.7205.102.camel@laptop>
2009-09-11 7:45 ` Xiao Guangrong
2009-09-11 7:50 ` Peter Zijlstra
2009-09-11 19:08 ` Suresh Siddha
2009-09-14 7:22 ` Xiao Guangrong
2009-09-15 0:16 ` Suresh Siddha
2009-09-15 2:03 ` Xiao Guangrong
2009-09-16 2:20 ` Suresh Siddha
2009-09-17 3:00 ` Xiao Guangrong
2009-09-17 7:45 ` Peter Zijlstra
2009-09-19 2:16 ` Suresh Siddha [this message]
2009-09-21 2:55 ` Xiao Guangrong
2009-09-21 3:11 ` Suresh Siddha
2009-09-21 4:04 ` Xiao Guangrong
2009-09-22 5:32 ` Suresh Siddha
2009-09-22 6:52 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253326599.3948.732.camel@sbs-t61.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mm-commits@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=peterz@infradead.org \
--cc=rusty@rustcorp.com.au \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®