From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com,
lizf@cn.fujitsu.com, peterz@infradead.org, fweisbec@gmail.com,
tglx@linutronix.de, jbaron@redhat.com, mhiramat@redhat.com,
mingo@elte.hu
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:tracing/urgent] tracing: Allocate the ftrace event profile buffer dynamically
Date: Sat, 19 Sep 2009 09:47:15 -0400 [thread overview]
Message-ID: <1253368035.20020.339.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <tip-20ab4425a77a1f34028cc6ce57053c22c184ba5f@git.kernel.org>
On Sat, 2009-09-19 at 10:06 +0000, tip-bot for Frederic Weisbecker
wrote:
> Commit-ID: 20ab4425a77a1f34028cc6ce57053c22c184ba5f
> Gitweb: http://git.kernel.org/tip/20ab4425a77a1f34028cc6ce57053c22c184ba5f
> Author: Frederic Weisbecker <fweisbec@gmail.com>
> AuthorDate: Fri, 18 Sep 2009 06:10:28 +0200
> Committer: Frederic Weisbecker <fweisbec@gmail.com>
> CommitDate: Fri, 18 Sep 2009 07:25:44 +0200
>
> tracing: Allocate the ftrace event profile buffer dynamically
>
> Currently the trace event profile buffer is allocated in the stack. But
> this may be too much for the stack, as the events can have large
> statically defined field size and can also grow with dynamic arrays.
>
> Allocate two per cpu buffer for all profiled events. The first cpu
> buffer is used to host every non-nmi context traces. It is protected
> by disabling the interrupts while writing and committing the trace.
>
> The second buffer is reserved for nmi. So that there is no race between
> them and the first buffer.
>
> The whole write/commit section is rcu protected because we release
> these buffers while deactivating the last profiling trace event.
>
> v2: Move the buffers from trace_event to be global, as pointed by
> Steven Rostedt.
OK, now I'm confused ;-)
This version looks like the correct one.
-- Steve
>
> v3: Fix the syscall events to handle the profiling buffer races
> by disabling interrupts, now that the buffers are globals.
>
> Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Li Zefan <lizf@cn.fujitsu.com>
> Cc: Jason Baron <jbaron@redhat.com>
> Cc: Masami Hiramatsu <mhiramat@redhat.com>
> Cc: Ingo Molnar <mingo@elte.hu>
>
next parent reply other threads:[~2009-09-19 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-20ab4425a77a1f34028cc6ce57053c22c184ba5f@git.kernel.org>
2009-09-19 13:47 ` Steven Rostedt [this message]
[not found] <tip-31dcbc09033bd90190e90d943863d7ef9f39b93b@git.kernel.org>
2009-09-19 13:45 ` Steven Rostedt
2009-09-19 16:52 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253368035.20020.339.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®