From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
rfoss@kernel.org, todor.too@gmail.com, agross@kernel.org,
andersson@kernel.org, mchehab@kernel.org,
hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com,
sakari.ailus@linux.intel.com, andrey.konovalov@linaro.org
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 07/17] media: qcom: camss: Pass CAMSS subdev callbacks via resource ops pointer
Date: Fri, 8 Sep 2023 11:14:49 +0200 [thread overview]
Message-ID: <1253a158-e867-4a9f-b846-d008e2756d74@linaro.org> (raw)
In-Reply-To: <20230907164410.36651-8-bryan.odonoghue@linaro.org>
On 7.09.2023 18:44, Bryan O'Donoghue wrote:
> It is possible to pass all of the CAMSS subdevice internal operations
> pointers from the controlling resources structure with an additional
> pointer added to the resources structure.
>
> This allows for the removal of most of the probe-time control structures.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
[...]
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index 54886a2a449b0..12131d9ea7ca8 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -42,7 +42,8 @@ static const struct camss_subdev_resources csiphy_res_8x16[] = {
> { 0 },
> { 100000000, 200000000 } },
> .reg = { "csiphy0", "csiphy0_clk_mux" },
> - .interrupt = { "csiphy0" }
> + .interrupt = { "csiphy0" },
> + .ops = &csiphy_ops_2ph_1_0
I'd really vouch for adding commas at the end, so that the
next diffs will be smaller
otherwise
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
next prev parent reply other threads:[~2023-09-08 9:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 16:43 [PATCH v4 00/17] media: qcom: camss: Add parameter passing to remove several outstanding bugs Bryan O'Donoghue
2023-09-07 16:43 ` [PATCH v4 01/17] media: qcom: camss: Amalgamate struct resource with struct resource_ispif Bryan O'Donoghue
2023-09-07 16:43 ` [PATCH v4 02/17] media: qcom: camss: Rename camss struct resources to camss_subdev_resources Bryan O'Donoghue
2023-09-08 9:13 ` Konrad Dybcio
2023-09-07 16:43 ` [PATCH v4 03/17] media: qcom: camss: Start to move to module compat matched resources Bryan O'Donoghue
2023-09-07 16:43 ` [PATCH v4 04/17] media: qcom: camss: Pass icc bandwidth table as a platform parameter Bryan O'Donoghue
2023-09-07 16:43 ` [PATCH v4 05/17] media: qcom: camss: Pass remainder of variables as resources Bryan O'Donoghue
2023-09-07 16:43 ` [PATCH v4 06/17] media: qcom: camss: Pass line_num from compat resources Bryan O'Donoghue
2023-09-07 16:44 ` [PATCH v4 07/17] media: qcom: camss: Pass CAMSS subdev callbacks via resource ops pointer Bryan O'Donoghue
2023-09-08 9:14 ` Konrad Dybcio [this message]
2023-09-07 16:44 ` [PATCH v4 08/17] media: qcom: camss: Assign the correct number of RDIs per VFE Bryan O'Donoghue
2023-09-07 16:44 ` [PATCH v4 09/17] media: qcom: camss: Remove special case for VFE get/put Bryan O'Donoghue
2023-09-07 16:44 ` [PATCH v4 10/17] media: qcom: camss: Untangle if/else spaghetti in camss Bryan O'Donoghue
2023-09-07 16:44 ` [PATCH v4 11/17] media: qcom: camss: Allow clocks vfeN vfe_liteN or vfe_lite Bryan O'Donoghue
2023-09-08 9:19 ` Konrad Dybcio
2023-09-07 16:44 ` [PATCH v4 12/17] media: qcom: camss: Functionally decompose CSIPHY clock lookups Bryan O'Donoghue
2023-09-08 9:20 ` Konrad Dybcio
2023-09-08 9:21 ` Konrad Dybcio
2023-09-07 16:44 ` [PATCH v4 13/17] media: qcom: camss: Fix support for setting CSIPHY clock name csiphyX Bryan O'Donoghue
2023-09-07 16:44 ` [PATCH v4 14/17] media: qcom: camss: Support RDI3 for VFE 17x Bryan O'Donoghue
2023-09-07 16:44 ` [PATCH v4 15/17] media: qcom: camss: Move vfe_disable into a common routine where applicable Bryan O'Donoghue
2023-09-08 10:02 ` Konrad Dybcio
2023-09-08 10:04 ` Konrad Dybcio
2023-09-08 10:21 ` Bryan O'Donoghue
2023-09-08 10:24 ` Konrad Dybcio
2023-09-08 10:36 ` Bryan O'Donoghue
2023-09-11 9:10 ` Hans Verkuil
2023-09-07 16:44 ` [PATCH v4 16/17] media: qcom: camss: Propagate vfe_reset error up the callstack Bryan O'Donoghue
2023-09-08 10:03 ` Konrad Dybcio
2023-09-07 16:44 ` [PATCH v4 17/17] media: qcom: camss: Comment CSID dt_id field Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253a158-e867-4a9f-b846-d008e2756d74@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andrey.konovalov@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®