From: Joe Perches <joe@perches.com>
To: Bruce Jones <brucej97223@gmail.com>
Cc: gregkh@suse.de, wfp5@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: Updated: [PATCH] staging: comedi: CodingStyle cleanup for drivers/acl7225b.c
Date: Mon, 28 Sep 2009 15:18:38 -0700 [thread overview]
Message-ID: <1254176318.28232.388.camel@Joe-Laptop.home> (raw)
In-Reply-To: <4AC1343D.3040606@gmail.com>
On Mon, 2009-09-28 at 15:10 -0700, Bruce Jones wrote:
> Cleanup the printk's in this driver to use KERN_foo log
> levels.
> + printk(KERN_INFO "comedi%d: acl7225b: board=%s 0x%04x\n", dev->minor,
> this_board->name, iobase);
> if (!request_region(iobase, iorange, "acl7225b")) {
> - printk("I/O port conflict\n");
> + printk(KERN_CONT "I/O port conflict\n");
This should not be KERN_CONT but KERN_INFO or KERN_ERR
and should probably have a "comedi%d:" leader.
Maybe:
printk(KERN_ERR "comedi%d: request_region failed - I/O port conflict\n");
cheers, Joe
next prev parent reply other threads:[~2009-09-28 22:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 22:10 Bruce Jones
2009-09-28 22:18 ` Joe Perches [this message]
2009-09-29 17:26 ` Bruce Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254176318.28232.388.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=brucej97223@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=wfp5@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®