mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Dave Hansen <dave@sr71.net>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	rpurdie@rpsys.net, rgirod@confocus.com,
	Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH] LED driver for Intel NAS SS4200 series (v4)
Date: Thu, 01 Oct 2009 15:37:42 -0700	[thread overview]
Message-ID: <1254436662.1799.117.camel@Joe-Laptop.home> (raw)
In-Reply-To: <1254436115-7595-1-git-send-email-dave@sr71.net>

On Thu, 2009-10-01 at 15:28 -0700, Dave Hansen wrote:
> Changes from last version
> * Changed logging functions to use cleaner helpers
> diff --git a/drivers/leds/leds-ss4200.c b/drivers/leds/leds-ss4200.c
[]
> +#ifdef pr_fmt
> +#undef pr_fmt
> +#endif
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

Hi Dave.

Thanks for doing this.

Minor nit: I think the preferred style is to
put the #define pr_fmt before any #include.

cheers, Joe



      reply	other threads:[~2009-10-01 22:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-01 22:28 Dave Hansen
2009-10-01 22:37 ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1254436662.1799.117.camel@Joe-Laptop.home \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=dave@sr71.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rgirod@confocus.com \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®