From: Joe Perches <joe@perches.com>
To: Andy Whitcroft <apw@canonical.com>
Cc: Jan Ceuleers <jan.ceuleers@computer.org>,
David Miller <davem@davemloft.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] scripts/checkpatch.pl: Add WARN on sizeof(&
Date: Sat, 03 Oct 2009 18:12:49 -0700 [thread overview]
Message-ID: <1254618769.1799.280.camel@Joe-Laptop.home> (raw)
In-Reply-To: <4AC77003.9090805@computer.org>
On Sat, 2009-10-03 at 17:38 +0200, Jan Ceuleers wrote:
> David Miller wrote:
> > Any time you see "&" in a sizeof() expression, it's almost
> > certainly a bug. Something for the folks with automated
> > tools to look for if they haven't already :-)
>
> Your remark prompted me to find four more instances of such bugs
> (none of which in the networking bits). I have submitted patches.
Perhaps a checkpatch test.
---
sizeof(&foo) is frequently an error. Warn on its use.
Signed-off-by: Joe Perches <joe@perches.com>
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 87bbb8b..596dd72 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2534,6 +2534,11 @@ sub process {
WARN("plain inline is preferred over $1\n" . $herecurr);
}
+# check for sizeof(&)
+ if ($line =~ /\bsizeof\s*\(\s*\&/) {
+ WARN("sizeof(& should be avoided\n" . $herecurr);
+ }
+
# check for new externs in .c files.
if ($realfile =~ /\.c$/ && defined $stat &&
$stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)
next prev parent reply other threads:[~2009-10-04 1:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-02 9:30 [PATCH] net: Fix wrong sizeof Jean Delvare
2009-10-02 15:14 ` Randy Dunlap
2009-10-02 16:54 ` David Miller
[not found] ` <4AC77003.9090805@computer.org>
2009-10-04 1:12 ` Joe Perches [this message]
2009-10-05 7:59 ` [PATCH] scripts/checkpatch.pl: Add WARN on sizeof(& Américo Wang
2009-10-26 11:17 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254618769.1799.280.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=davem@davemloft.net \
--cc=jan.ceuleers@computer.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®