From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753760AbZJEUcH (ORCPT ); Mon, 5 Oct 2009 16:32:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752897AbZJEUcG (ORCPT ); Mon, 5 Oct 2009 16:32:06 -0400 Received: from mail.perches.com ([173.55.12.10]:1875 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752441AbZJEUcF (ORCPT ); Mon, 5 Oct 2009 16:32:05 -0400 Subject: Re: [PATCH 15/21] kernel/power/: use pr_ and add pr_fmt(fmt) From: Joe Perches To: "Rafael J. Wysocki" Cc: linux-kernel@vger.kernel.org, Pavel Machek , Len Brown , linux-pm@lists.linux-foundation.org In-Reply-To: <200910052143.37985.rjw@sisk.pl> References: <17906d40d7b002380e893d49639ba3f1e7bdb3a0.1254701151.git.joe@perches.com> <200910052143.37985.rjw@sisk.pl> Content-Type: text/plain; charset="UTF-8" Date: Mon, 05 Oct 2009 13:31:27 -0700 Message-Id: <1254774687.1799.566.camel@Joe-Laptop.home> Mime-Version: 1.0 X-Mailer: Evolution 2.28.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2009-10-05 at 21:43 +0200, Rafael J. Wysocki wrote: > On Monday 05 October 2009, Joe Perches wrote: > > Added #define pr_fmt(fmt) "PM: " fmt > > Converted printk(KERN_ to pr_( > > Removed "PM: " prefix > > Added pr_fmt() to __initdata strings > > Well, can you please tell me what actually is wrong with the current code? Not much. There were a couple of trivial corrections, but perhaps the changes add a bit more flexibility and regularity. Effective trivial changes: o Added KERN_CONT (pr_cont) to a couple of messages o Added "PM: " (pr_info) to an #ifdef'd message o Added "PM: " (pr_info) to a printk "Syncing filesystems ..." in power/user.c cheers, Joe