Re: [PATCH 3/3] tracing/syscalls: Use long for syscall ret format and field definitions

[Tom Zanussi <tzanussi@gmail.com>]

On Tue, 2009-10-06 at 09:15 +0200, Frédéric Weisbecker wrote:
> 2009/10/6, Tom Zanussi <tzanussi@gmail.com>:
> > The syscall event definitions use long for the syscall exit ret value,
> > but unsigned long for the same thing in the format and field
> > definitions.  Change them all to long.
> 
> 
> Thanks.
> 
> We may perhaps also want to change struct syscall_trace_exit
> according to that?
> That won't change the code behaviour, just the logic while
> reviewing.
> 
> It's just a neat, this patch itself is fine.
> 

Yeah, that should have been part of it too.  I'll submit another patch
later doing that.

Tom

> 
> >
> > Signed-off-by: Tom Zanussi <tzanussi@gmail.com>
> > ---
> >  kernel/trace/trace_syscalls.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
> > index 9fbce6c..527e17e 100644
> > --- a/kernel/trace/trace_syscalls.c
> > +++ b/kernel/trace/trace_syscalls.c
> > @@ -166,7 +166,7 @@ int syscall_exit_format(struct ftrace_event_call *call,
> > struct trace_seq *s)
> >  			       "\tfield:%s %s;\toffset:%zu;\tsize:%zu;\n"
> >  			       "\tfield:%s %s;\toffset:%zu;\tsize:%zu;\n",
> >  			       SYSCALL_FIELD(int, nr),
> > -			       SYSCALL_FIELD(unsigned long, ret));
> > +			       SYSCALL_FIELD(long, ret));
> >  	if (!ret)
> >  		return 0;
> >
> > @@ -212,7 +212,7 @@ int syscall_exit_define_fields(struct ftrace_event_call
> > *call)
> >  	if (ret)
> >  		return ret;
> >
> > -	ret = trace_define_field(call, SYSCALL_FIELD(unsigned long, ret), 0,
> > +	ret = trace_define_field(call, SYSCALL_FIELD(long, ret), 0,
> >  				 FILTER_OTHER);
> >
> >  	return ret;
> > --
> > 1.6.4.GIT
> >
> >