mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Cc: mingo@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org,
	torvalds@linux-foundation.org
Subject: Re: [PATCH 1/7] printk: clean up return value
Date: Wed, 07 Oct 2009 06:55:02 -0700	[thread overview]
Message-ID: <1254923702.2134.358.camel@Joe-Laptop.home> (raw)
In-Reply-To: <1254904787-11323-2-git-send-email-alan-jenkins@tuffmail.co.uk>

On Wed, 2009-10-07 at 09:39 +0100, Alan Jenkins wrote:
> Commit 5fd29d6 "printk: clean up handling of log-levels and newlines"
> causes printk() to return the wrong number of characters.

Maybe it'd be better to return void?

These may be the only uses of the value returned,
and both files are trivial to modify.

kernel/lockdep.c:	len += printk("%*s   %s", depth, "", usage_str[bit]);
kernel/lockdep.c:	len += printk(" at:\n");
drivers/char/mem.c:	ret = printk("%s", tmp);



  reply	other threads:[~2009-10-07 13:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-07  8:39 printk: fix loglevels as used by x86 stack dump code Alan Jenkins
2009-10-07  8:39 ` [PATCH 1/7] printk: clean up return value Alan Jenkins
2009-10-07 13:55   ` Joe Perches [this message]
2009-10-07 15:36   ` Linus Torvalds
2009-10-07 16:25     ` Alan Jenkins
2009-10-07 16:36     ` Joe Perches
2009-10-07 16:57       ` Alan Jenkins
2009-10-07 17:42         ` Joe Perches
2009-10-07  8:39 ` [PATCH 2/7] kmsg: no need to limit the return value of printk Alan Jenkins
2009-10-07  8:39 ` [PATCH 3/7] printk: move the printing of the loglevel tag into a separate function Alan Jenkins
2009-10-07  8:39 ` [PATCH 4/7] printk: remove redundant test Alan Jenkins
2009-10-07  8:39 ` [PATCH 5/7] printk: fix printk(KERN_EMERG) followed by printk("emergency message\n") Alan Jenkins
2009-10-07  8:39 ` [PATCH 6/7] x86 dumpstack: fix printing of stack dump loglevels Alan Jenkins
2009-10-07 14:36   ` Linus Torvalds
2009-10-07 16:35     ` Alan Jenkins
2009-10-07  8:39 ` [PATCH 7/7] x86 dumpstack: fix log level of the first line in the stack dump Alan Jenkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1254923702.2134.358.camel@Joe-Laptop.home \
    --to=joe@perches.com \
    --cc=alan-jenkins@tuffmail.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®