mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joerg Roedel <joerg.roedel@amd.com>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Joerg Roedel <joerg.roedel@amd.com>
Subject: [PATCH 03/10] KVM: SVM: Move nested INTR #vmexit into preemtible code
Date: Wed, 7 Oct 2009 16:31:21 +0200	[thread overview]
Message-ID: <1254925888-13743-4-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1254925888-13743-1-git-send-email-joerg.roedel@amd.com>

This patch makes use of the KVM_REQ_VMEXIT to move the
emulation of #vmexit(INTR) out of non-preemptible code.

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 arch/x86/kvm/svm.c |   18 ++++++++++++++++--
 1 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index b6ce1a9..7015680 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -1379,8 +1379,14 @@ static inline int nested_svm_intr(struct vcpu_svm *svm)
 
 	svm->vmcb->control.exit_code = SVM_EXIT_INTR;
 
-	if (nested_svm_exit_handled(svm)) {
-		nsvm_printk("VMexit -> INTR\n");
+	if (svm->nested.intercept & 1ULL) {
+		/*
+		 * The #vmexit can't be emulated here directly because this
+		 * code path runs with irqs and preemtion disabled and a
+		 * #vmexit emulation might sleep. Only set the request bit for
+		 * the #vmexit here.
+		 */
+		set_bit(KVM_REQ_VMEXIT, &svm->vcpu.requests);
 		return 1;
 	}
 
@@ -2859,6 +2865,13 @@ static bool svm_gb_page_enable(void)
 	return true;
 }
 
+static void svm_emulate_vmexit(struct kvm_vcpu *vcpu)
+{
+	struct vcpu_svm *svm = to_svm(vcpu);
+
+	nested_svm_vmexit(svm);
+}
+
 static struct kvm_x86_ops svm_x86_ops = {
 	.cpu_has_kvm_support = has_svm,
 	.disabled_by_bios = is_disabled,
@@ -2923,6 +2936,7 @@ static struct kvm_x86_ops svm_x86_ops = {
 
 	.exit_reasons_str = svm_exit_reasons_str,
 	.gb_page_enable = svm_gb_page_enable,
+	.emulate_vmexit = svm_emulate_vmexit,
 };
 
 static int __init svm_init(void)
-- 
1.6.4.3



  parent reply	other threads:[~2009-10-07 14:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-07 14:31 [PATCH 0/10] KVM: Nested SVM fixes and tracepoint conversion Joerg Roedel
2009-10-07 14:31 ` [PATCH 01/10] KVM: SVM: Notify nested hypervisor of lost event injections Joerg Roedel
2009-10-07 14:31 ` [PATCH 02/10] KVM: X86: Add KVM_REQ_VMEXIT to trigger a nested #vmexit Joerg Roedel
2009-10-07 14:31 ` Joerg Roedel [this message]
2009-10-07 20:58   ` [PATCH 03/10] KVM: SVM: Move nested INTR #vmexit into preemtible code Marcelo Tosatti
2009-10-08  9:12     ` Joerg Roedel
2009-10-07 14:31 ` [PATCH 04/10] KVM: SVM: Add tracepoint for nested vmrun Joerg Roedel
2009-10-07 14:31 ` [PATCH 05/10] KVM: SVM: Add tracepoint for nested #vmexit Joerg Roedel
2009-10-07 14:31 ` [PATCH 06/10] KVM: SVM: Add tracepoint for injected #vmexit Joerg Roedel
2009-10-07 14:31 ` [PATCH 07/10] KVM: SVM: Add tracepoint for #vmexit because intr pending Joerg Roedel
2009-10-07 14:31 ` [PATCH 08/10] KVM: SVM: Add tracepoint for invlpga instruction Joerg Roedel
2009-10-07 14:31 ` [PATCH 09/10] KVM: SVM: Add tracepoint for skinit instruction Joerg Roedel
2009-10-07 14:31 ` [PATCH 10/10] KVM: SVM: Remove nsvm_printk debugging code Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1254925888-13743-4-git-send-email-joerg.roedel@amd.com \
    --to=joerg.roedel@amd.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®