mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: jolsa@redhat.com
To: mingo@elte.hu, rostedt@goodmis.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] tracing - correct module boundaries for ftrace_release
Date: Wed,  7 Oct 2009 19:00:34 +0200	[thread overview]
Message-ID: <1254934835-363-2-git-send-email-jolsa@redhat.com> (raw)
In-Reply-To: <1254934835-363-1-git-send-email-jolsa@redhat.com>

When the module is about the unload we release its call records.
The ftrace_release function was given wrong values representing
the module core boundaries, thus not releasing its call records.

wbr,
jirka


Signed-off-by: Jiri Olsa <jolsa@redhat.com>
---
 kernel/trace/ftrace.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 9a72853..09971c5 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -2652,9 +2652,9 @@ static int ftrace_module_notify(struct notifier_block *self,
 				   mod->num_ftrace_callsites);
 		break;
 	case MODULE_STATE_GOING:
-		ftrace_release(mod->ftrace_callsites,
-			       mod->ftrace_callsites +
-			       mod->num_ftrace_callsites);
+		ftrace_release(mod->module_core,
+			       mod->module_core +
+			       mod->core_size);
 		break;
 	}
 

  reply	other threads:[~2009-10-07 17:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-07 17:00 [PATCH 0/2] tracing - wrong scale in ftrace_release jolsa
2009-10-07 17:00 ` jolsa [this message]
2009-10-07 17:00 ` [PATCH 2/2] tracing - correct module boundaries for ftrace_release jolsa
2009-10-07 17:14   ` Steven Rostedt
2009-10-08 13:47   ` [tip:tracing/urgent] tracing: " tip-bot for jolsa@redhat.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1254934835-363-2-git-send-email-jolsa@redhat.com \
    --to=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome