mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tyrel Datwyler <tyreld@linux.ibm.com>
To: Tyllis Xu <livelycarpet87@gmail.com>
Cc: James.Bottomley@HansenPartnership.com,
	martin.petersen@oracle.com, brking@linux.vnet.ibm.com,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, danisjiang@gmail.com,
	ychen@northwestern.edu
Subject: Re: [PATCH] scsi: ibmvfc: fix OOB access in ibmvfc_discover_targets_done()
Date: Wed, 18 Mar 2026 16:07:40 -0700	[thread overview]
Message-ID: <1254b232-4a90-4358-ac56-b5ddb7585ef1@linux.ibm.com> (raw)
In-Reply-To: <20260314170151.548614-1-LivelyCarpet87@gmail.com>

On 3/14/26 10:01 AM, Tyllis Xu wrote:
> A malicious or compromised VIO server can return a num_written value in
> the discover targets MAD response that exceeds max_targets. This value
> is stored directly in vhost->num_targets without validation, and is then
> used as the loop bound in ibmvfc_alloc_targets() to index into disc_buf[],
> which is only allocated for max_targets entries. Indices at or beyond
> max_targets access kernel memory outside the DMA-coherent allocation.
> The out-of-bounds data is subsequently embedded in Implicit Logout and
> PLOGI MADs that are sent back to the VIO server, leaking kernel memory.
> 
> Fix by clamping num_written to max_targets before storing it.
> 
> Fixes: 072b91f9c651 ("[SCSI] ibmvfc: IBM Power Virtual Fibre Channel Adapter Client Driver")
> Reported-by: Yuhao Jiang <danisjiang@gmail.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Tyllis Xu <LivelyCarpet87@gmail.com>

Acked-by: Tyrel Datwyler <tyreld@linux.ibm.com>

  parent reply	other threads:[~2026-03-18 23:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-14 17:01 Tyllis Xu
2026-03-16 14:04 ` Dave Marquardt
2026-03-18 23:07 ` Tyrel Datwyler [this message]
2026-03-20  2:36 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1254b232-4a90-4358-ac56-b5ddb7585ef1@linux.ibm.com \
    --to=tyreld@linux.ibm.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=brking@linux.vnet.ibm.com \
    --cc=danisjiang@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=livelycarpet87@gmail.com \
    --cc=martin.petersen@oracle.com \
    --cc=stable@vger.kernel.org \
    --cc=ychen@northwestern.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®