From: Steven Rostedt <rostedt@goodmis.org>
To: jolsa@redhat.com
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing - enable records during the module load
Date: Sat, 10 Oct 2009 11:26:41 -0400 [thread overview]
Message-ID: <1255188401.1696.1201.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1255183220-15640-1-git-send-email-jolsa@redhat.com>
On Sat, 2009-10-10 at 16:00 +0200, jolsa@redhat.com wrote:
> I was debuging some module using "function" and "function_graph" tracers
> and noticed, that if you load module after you enabled tracing, the module's
> hooks will convert only to NOP instructions.
Yeah, I knew when I wrote this that new modules loaded during tracing
would just be initialized as nops, and not become part of that trace.
They will become part of later traces if the function tracing is stopped
and started again.
Actually, I took that as a safety feature, since most bad things can
happen when modules load and unload. But, I think your patch is still
safe. I'll apply it, play with it a bit, then queue it up for 2.6.33.
Thanks,
-- Steve
>
> The attached patch enables modules' hooks if there's function
> trace allready on, thus allowing to trace module functions.
next prev parent reply other threads:[~2009-10-10 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-10 14:00 jolsa
2009-10-10 15:26 ` Steven Rostedt [this message]
2009-10-10 15:29 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255188401.1696.1201.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®