From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Len Brown <lenb@kernel.org>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 5/7] x86/PCI: print resources consistently with %pRt
Date: Sat, 10 Oct 2009 09:36:40 -0600 [thread overview]
Message-ID: <1255189000.30901.11.camel@dc7800.home> (raw)
In-Reply-To: <alpine.LFD.2.00.0910091707380.3912@localhost.localdomain>
On Fri, 2009-10-09 at 17:14 -0400, Len Brown wrote:
> > The message changes like this:
> >
> > -PCI: Failed to allocate to allocate 0x0-0x3fff from PCI IO for PCI Bus 0000:00
> > +pci_root PNP0A03:01: can't allocate [io 0x0000-0x3fff]
> >
> > I don't think changing "PCI IO" to "io" is really a problem. In fact,
> > strictly speaking, "PCI IO" is the wrong name for ioport_resource --
> > we're talking about a host bridge, and the upstream side is not PCI
> > at all.
> >
> > However, I do think it would be more useful to mention the fact that
> > we failed to allocate a *window*, e.g.,
> >
> > pci_root PNP0A03:00: can't allocate host bridge window [io 0x0000-0x3fff]
> >
> > I did consider keeping the PCI bus ("0000:00"), but I decided we
> > already have that information here:
> >
> > ACPI: PCI Root Bridge [PCI0] (0000:00)
> >
> > and it doesn't seem worthwhile to me to repeat the bus number in all
> > the host bridge-related messages. Right now, there's nothing to tie
> > the PCI0 to the PNP0A03:00 (and "PCI0" shouldn't be exposed to users
> > anyway), but someday when I finally convince Len to use dev_printk
> > in ACPI, it could look something like this:
> >
> > pci_root PNP0A03:00: PCI host bridge to pci_bus 0000:00
>
> The last time we looked at using dev_printk() in ACPI,
> it looked like the leading ACPI: would go away, and the
> concern was that would hinder, rather than help, people
> in reporting issues to the right place.
>
> I have no problem with using dev_printk() where it makes sense,
> but only if it makes the message more useful rather than
> less useful.
Yes, I'm sorry, that was kind of a low blow that didn't represent your
concerns fairly.
> BTW. I like the consistency provided by the series at hand.
> I assume that it will go through Jesse's, and for that,
> consider the relevant bits...
>
> Acked-by: Len Brown <len.brown@intel.com>
Thanks. I'm planning to post an updated series soon. Joe Perches
suggested reducing the stack usage in vsprintf, so I'm working on that,
and I might add another message or two.
Bjorn
next prev parent reply other threads:[~2009-10-10 15:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 21:33 [PATCH 0/7] PCI, PNP: print resources consistently Bjorn Helgaas
2009-10-06 21:33 ` [PATCH 1/7] vsprintf: fix io/mem resource width Bjorn Helgaas
2009-10-26 20:40 ` Jesse Barnes
2009-10-06 21:33 ` [PATCH 2/7] vsprintf: add %pR support for IRQ and DMA resources Bjorn Helgaas
2009-10-06 21:33 ` [PATCH 3/7] vsprintf: add %pRt, %pRf to print struct resource details Bjorn Helgaas
2009-10-06 21:33 ` [PATCH 4/7] PCI: print resources consistently with %pRt Bjorn Helgaas
2009-10-06 21:33 ` [PATCH 5/7] x86/PCI: " Bjorn Helgaas
2009-10-07 18:43 ` Yinghai Lu
2009-10-07 19:15 ` Bjorn Helgaas
2009-10-09 21:14 ` Len Brown
2009-10-10 15:36 ` Bjorn Helgaas [this message]
2009-10-06 21:33 ` [PATCH 6/7] ia64/PCI: " Bjorn Helgaas
2009-10-06 21:34 ` [PATCH 7/7] PNP: " Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255189000.30901.11.camel@dc7800.home \
--to=bjorn.helgaas@hp.com \
--cc=jbarnes@virtuousgeek.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®