From: Tejun Heo <tj@kernel.org>
To: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au,
cl@linux-foundation.org, mingo@redhat.com, tglx@linutronix.de,
akpm@linux-foundation.org, rostedt@goodmis.org, hpa@zytor.com,
cebbert@redhat.com
Cc: Tejun Heo <tj@kernel.org>, Nick Piggin <npiggin@suse.de>
Subject: [PATCH 01/16] vmalloc: fix use of non-existent percpu variable in put_cpu_var()
Date: Wed, 14 Oct 2009 15:01:50 +0900 [thread overview]
Message-ID: <1255500125-3210-2-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1255500125-3210-1-git-send-email-tj@kernel.org>
vmalloc used non-existent percpu variable vmap_cpu_blocks instead of
the intended vmap_block_queue. This went unnoticed because
put_cpu_var() didn't evaluate the parameter. Fix it.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Nick Piggin <npiggin@suse.de>
---
mm/vmalloc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 69511e6..b65cfe4 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -760,7 +760,7 @@ static struct vmap_block *new_vmap_block(gfp_t gfp_mask)
spin_lock(&vbq->lock);
list_add(&vb->free_list, &vbq->free);
spin_unlock(&vbq->lock);
- put_cpu_var(vmap_cpu_blocks);
+ put_cpu_var(vmap_block_queue);
return vb;
}
@@ -825,7 +825,7 @@ again:
}
spin_unlock(&vb->lock);
}
- put_cpu_var(vmap_cpu_blocks);
+ put_cpu_var(vmap_block_queue);
rcu_read_unlock();
if (!addr) {
--
1.6.4.2
next prev parent reply other threads:[~2009-10-14 6:04 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 6:01 [RFC percpu#for-next] percpu: drop per_cpu__ prefix and add sparse annotations, take#2 Tejun Heo
2009-10-14 6:01 ` Tejun Heo [this message]
2009-10-14 15:06 ` [PATCH 01/16] vmalloc: fix use of non-existent percpu variable in put_cpu_var() Christoph Lameter
2009-10-15 9:10 ` Tejun Heo
2009-10-14 6:01 ` [PATCH 02/16] percpu: make alloc_percpu() handle array types Tejun Heo
2009-10-14 6:01 ` [PATCH 03/16] percpu: remove some sparse warnings Tejun Heo
2009-10-14 14:20 ` Christoph Lameter
2009-10-14 6:01 ` [PATCH 04/16] percpu: make percpu symbols under kernel/ and mm/ unique Tejun Heo
2009-10-14 6:01 ` [PATCH 05/16] percpu: make percpu symbols in tracer unique Tejun Heo
2009-10-14 6:01 ` [PATCH 06/16] percpu: make percpu symbols in oprofile unique Tejun Heo
2009-10-14 6:01 ` [PATCH 07/16] percpu: make percpu symbols in cpufreq unique Tejun Heo
2009-10-14 6:01 ` [PATCH 08/16] percpu: make percpu symbols in xen unique Tejun Heo
2009-10-14 6:01 ` [PATCH 09/16] percpu: make percpu symbols in x86 unique Tejun Heo
2009-10-14 6:01 ` [PATCH 10/16] percpu: make percpu symbols in powerpc unique Tejun Heo
2009-10-27 3:19 ` Benjamin Herrenschmidt
2009-10-14 6:02 ` [PATCH 11/16] percpu: make percpu symbols in ia64 unique Tejun Heo
2009-10-14 6:02 ` [PATCH 12/16] percpu: make misc percpu symbols unique Tejun Heo
2009-10-14 6:02 ` [PATCH 13/16] percpu: remove per_cpu__ prefix Tejun Heo
2009-10-14 14:36 ` Christoph Lameter
2009-10-14 16:42 ` Luck, Tony
2009-10-14 17:38 ` H. Peter Anvin
2009-10-14 18:26 ` Christoph Lameter
2009-10-15 8:57 ` Tejun Heo
2009-10-14 18:22 ` Christoph Lameter
2009-10-14 18:36 ` Luck, Tony
2009-10-14 18:51 ` Christoph Lameter
2009-10-15 8:51 ` Tejun Heo
2009-10-16 16:23 ` Christoph Lameter
2009-10-15 9:24 ` Tejun Heo
2009-10-16 6:04 ` Michal Simek
2009-10-18 2:58 ` Tejun Heo
2009-10-19 13:41 ` Michal Simek
2009-10-29 11:11 ` Tejun Heo
2009-11-02 16:35 ` Michal Simek
2009-10-19 13:40 ` Michal Simek
2009-10-29 12:06 ` Tejun Heo
2009-10-14 6:02 ` [PATCH 14/16] percpu: make access macros universal Tejun Heo
2009-10-14 14:38 ` Christoph Lameter
2009-10-15 9:27 ` Tejun Heo
2009-10-14 6:02 ` [PATCH 15/16] percpu: add __percpu for sparse Tejun Heo
2009-10-14 6:02 ` [PATCH 16/16] percpu: make accessors check for percpu pointer in sparse Tejun Heo
2009-10-14 14:41 ` Christoph Lameter
2009-10-15 9:08 ` Tejun Heo
2009-10-29 13:40 ` [RFC percpu#for-next] percpu: drop per_cpu__ prefix and add sparse annotations, take#2 Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255500125-3210-2-git-send-email-tj@kernel.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cebbert@redhat.com \
--cc=cl@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=npiggin@suse.de \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome