From: Bryan Donlan <bdonlan@gmail.com>
To: Justin Piszcz <jpiszcz@lucidpixels.com>
Cc: bruce.w.allan@intel.com, linux-kernel@vger.kernel.org,
Bryan Donlan <bdonlan@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org
Subject: [PATCH] Add quirk for ACPI reboots on Intel DP55KG boards.
Date: Thu, 15 Oct 2009 18:29:56 -0400 [thread overview]
Message-ID: <1255645796-29944-1-git-send-email-bdonlan@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.0910151655590.4808@p34.internal.lan>
Keyboard-based and BIOS-based reboots don't work on Intel DP55KG boards;
use ACPI reboots instead.
Reported-By: Justin Piszcz <jpiszcz@lucidpixels.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
Signed-off-by: Bryan Donlan <bdonlan@gmail.com>
---
arch/x86/kernel/reboot.c | 23 +++++++++++++++++++++++
1 files changed, 23 insertions(+), 0 deletions(-)
Justin, could you give this patch a try? It should make the reboot=acpi
workaround automatic.
(x86 maintainers CC'd)
diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index a1a3cdd..67bfcef 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -134,6 +134,21 @@ static int __init set_bios_reboot(const struct dmi_system_id *d)
return 0;
}
+/*
+ * Some machines require the "reboot=a" commandline option.
+ * This quirk makes that automatic.
+ */
+static int __init set_acpi_reboot(const struct dmi_system_id *d)
+{
+ if (reboot_type != BOOT_ACPI) {
+ reboot_type = BOOT_ACPI;
+ printk(KERN_INFO "%s series board detected. Selecting ACPI "
+ "method for reboots.\n", d->ident);
+ }
+ return 0;
+}
+
+
static struct dmi_system_id __initdata reboot_dmi_table[] = {
{ /* Handle problems with rebooting on Dell E520's */
.callback = set_bios_reboot,
@@ -259,6 +274,14 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "SBC-FITPC2"),
},
},
+ { /* Handle problems with rebooting on Intel DP55KG */
+ .callback = set_acpi_reboot,
+ .ident = "Intel DP55KG",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "DP55KG"),
+ },
+ },
{ }
};
--
1.6.3.3
next prev parent reply other threads:[~2009-10-15 22:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 22:02 Intel DP55KG BIOS Bug (reboot hangs, is Intel aware of the problem?) Justin Piszcz
2009-10-15 17:23 ` H. Peter Anvin
2009-10-15 21:01 ` Justin Piszcz
2009-10-15 22:29 ` Bryan Donlan [this message]
2009-10-15 22:51 ` [PATCH] Add quirk for ACPI reboots on Intel DP55KG boards Justin Piszcz
2009-10-15 22:53 ` Justin Piszcz
2009-10-15 22:59 ` Justin Piszcz
2009-10-15 23:05 ` Bryan Donlan
2009-10-15 23:30 ` Justin Piszcz
2009-10-16 0:49 ` Bryan Donlan
2009-10-16 8:22 ` Justin Piszcz
2009-10-15 23:12 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255645796-29944-1-git-send-email-bdonlan@gmail.com \
--to=bdonlan@gmail.com \
--cc=bruce.w.allan@intel.com \
--cc=hpa@zytor.com \
--cc=jpiszcz@lucidpixels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome