From: Sam Ravnborg <sam@ravnborg.org>
To: kbuild <linux-kbuild@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCH 10/14] kbuild: drop include/asm
Date: Sun, 18 Oct 2009 10:15:19 +0200 [thread overview]
Message-ID: <1255853723-477-10-git-send-email-sam@ravnborg.org> (raw)
In-Reply-To: <20091018080635.GA13767@merkur.ravnborg.org>
We no longer use this directory for generated files and
all architectures has moved their header files so no
symlink tricks are needed either.
Drop the symlink and drop the ARCH check.
If we really need to check that the SRCARCH has not changed
when we build a kernel we can add this check back - but then we will
find a more convenient way to store the info.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
.gitignore | 1 -
Makefile | 40 ++--------------------------------------
2 files changed, 2 insertions(+), 39 deletions(-)
diff --git a/.gitignore b/.gitignore
index 5a5024a..624e3ab 100644
--- a/.gitignore
+++ b/.gitignore
@@ -44,7 +44,6 @@ Module.symvers
#
# Generated include files
#
-include/asm
include/config
include/linux/autoconf.h
include/linux/compile.h
diff --git a/Makefile b/Makefile
index 5e71b69..6570cf1 100644
--- a/Makefile
+++ b/Makefile
@@ -967,7 +967,7 @@ endif
prepare2: prepare3 outputmakefile
prepare1: prepare2 include/linux/version.h include/linux/utsrelease.h \
- include/asm include/config/auto.conf
+ include/config/auto.conf
$(cmd_crmodverdir)
archprepare: prepare1 scripts_basic
@@ -979,42 +979,6 @@ prepare0: archprepare FORCE
# All the preparing..
prepare: prepare0
-# The asm symlink changes when $(ARCH) changes.
-# Detect this and ask user to run make mrproper
-# If asm is a stale symlink (point to dir that does not exist) remove it
-define check-symlink
- set -e; \
- if [ -L include/asm ]; then \
- asmlink=`readlink include/asm | cut -d '-' -f 2`; \
- if [ "$$asmlink" != "$(SRCARCH)" ]; then \
- echo "ERROR: the symlink $@ points to asm-$$asmlink but asm-$(SRCARCH) was expected"; \
- echo " set ARCH or save .config and run 'make mrproper' to fix it"; \
- exit 1; \
- fi; \
- test -e $$asmlink || rm include/asm; \
- elif [ -d include/asm ]; then \
- echo "ERROR: $@ is a directory but a symlink was expected";\
- exit 1; \
- fi
-endef
-
-# We create the target directory of the symlink if it does
-# not exist so the test in check-symlink works and we have a
-# directory for generated filesas used by some architectures.
-define create-symlink
- if [ ! -L include/asm ]; then \
- $(kecho) ' SYMLINK $@ -> include/asm-$(SRCARCH)'; \
- if [ ! -d include/asm-$(SRCARCH) ]; then \
- mkdir -p include/asm-$(SRCARCH); \
- fi; \
- ln -fsn asm-$(SRCARCH) $@; \
- fi
-endef
-
-include/asm: FORCE
- $(Q)$(check-symlink)
- $(Q)$(create-symlink)
-
# Generate some files
# ---------------------------------------------------------------------------
@@ -1183,7 +1147,7 @@ CLEAN_FILES += vmlinux System.map \
# Directories & files removed with 'make mrproper'
MRPROPER_DIRS += include/config usr/include include/generated
-MRPROPER_FILES += .config .config.old include/asm .version .old_version \
+MRPROPER_FILES += .config .config.old .version .old_version \
include/linux/autoconf.h include/linux/version.h \
include/linux/utsrelease.h \
Module.symvers Module.markers tags TAGS cscope*
--
1.6.2.5
next prev parent reply other threads:[~2009-10-18 8:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-18 8:06 [PATCH 0/14 v2] kbuild: Move files to include/generated Sam Ravnborg
2009-10-18 8:15 ` [PATCH 01/14] kbuild: search arch/$ARCH/include before include/ Sam Ravnborg
2009-10-18 8:15 ` [PATCH 02/14] dontdiff: add generated Sam Ravnborg
2009-10-18 8:15 ` [PATCH 03/14] kbuild: move bounds.h to include/generated Sam Ravnborg
2009-10-18 8:15 ` [PATCH 04/14] kbuild: move asm-offsets.h " Sam Ravnborg
2009-10-18 8:15 ` [PATCH 05/14] ia64: move nr-irqs.h " Sam Ravnborg
2009-10-18 8:15 ` [PATCH 06/14] arm: move mach-types " Sam Ravnborg
2009-10-18 8:15 ` [PATCH 07/14] sh: move machtypes.h " Sam Ravnborg
2009-10-18 8:15 ` [PATCH 08/14] kbuild: drop include2/ used for O=... builds Sam Ravnborg
2009-10-18 8:15 ` [PATCH 09/14] kbuild: do not check for include/asm-$ARCH Sam Ravnborg
2009-10-18 8:15 ` Sam Ravnborg [this message]
2009-10-18 8:15 ` [PATCH 11/14] kbuild: move compile.h to include/generated Sam Ravnborg
2009-10-18 8:15 ` [PATCH 12/14] drop explicit include of autoconf.h Sam Ravnborg
2009-10-18 8:15 ` [PATCH 13/14] kbuild: move autoconf.h to include/generated Sam Ravnborg
2009-11-25 14:28 ` Michal Marek
2009-10-18 8:15 ` [PATCH 14/14] kbuild: move utsrelease.h " Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255853723-477-10-git-send-email-sam@ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome