From: Felipe Contreras <felipe.contreras@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-kernel@vger.kernel.org,
Felipe Contreras <felipe.contreras@gmail.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Sarah Sharp <sarah.a.sharp@linux.intel.com>,
Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org
Subject: [PATCH 1/7] usb: trivial cleanups
Date: Mon, 19 Oct 2009 01:54:28 +0300 [thread overview]
Message-ID: <1255906474-25091-2-git-send-email-felipe.contreras@gmail.com> (raw)
In-Reply-To: <1255906474-25091-1-git-send-email-felipe.contreras@gmail.com>
It seems 'min_t' was used before, and looks cleaner, plus white-space
stuff.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
drivers/usb/core/hcd.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 34de475..e6d754e 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -396,8 +396,7 @@ rh_string(int id, struct usb_hcd const *hcd, u8 *data, unsigned len)
case 0:
/* Array of LANGID codes (0x0409 is MSFT-speak for "en-us") */
/* See http://www.usb.org/developers/docs/USB_LANGIDs.pdf */
- if (len > 4)
- len = 4;
+ len = min_t(unsigned, len, sizeof(langids));
memcpy(data, langids, len);
return len;
case 1:
@@ -410,8 +409,8 @@ rh_string(int id, struct usb_hcd const *hcd, u8 *data, unsigned len)
break;
case 3:
/* Manufacturer */
- snprintf (buf, sizeof buf, "%s %s %s", init_utsname()->sysname,
- init_utsname()->release, hcd->driver->description);
+ snprintf(buf, sizeof buf, "%s %s %s", init_utsname()->sysname,
+ init_utsname()->release, hcd->driver->description);
s = buf;
break;
default:
--
1.6.5.1
next prev parent reply other threads:[~2009-10-18 22:55 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-18 22:54 [PATCH 0/7] trivial: fix some compilation warnings for 2.6.32-rc5 Felipe Contreras
2009-10-18 22:54 ` Felipe Contreras [this message]
2009-10-18 23:09 ` [PATCH 1/7] usb: trivial cleanups Felipe Contreras
2009-10-19 13:59 ` Alan Stern
2009-10-19 14:03 ` Felipe Contreras
2009-10-19 14:14 ` Alan Stern
2009-10-19 0:02 ` Greg KH
2009-10-19 1:04 ` Felipe Contreras
2009-10-18 22:54 ` [PATCH 2/7] ipc: fix trivial warning Felipe Contreras
2009-10-19 14:12 ` Jiri Kosina
2009-10-19 14:50 ` Felipe Contreras
2009-10-19 14:57 ` Jiri Kosina
2009-10-19 15:15 ` Felipe Contreras
2009-10-19 15:29 ` Jiri Kosina
2009-10-19 16:49 ` Felipe Contreras
2009-10-19 22:50 ` Jiri Kosina
2009-11-12 0:28 ` Felipe Contreras
2009-11-12 1:13 ` Jiri Kosina
2009-10-18 22:54 ` [PATCH 3/7] crypto: testmgr: fix warning Felipe Contreras
2009-10-19 13:52 ` Jiri Kosina
2009-10-19 13:58 ` Jarod Wilson
2009-10-19 14:03 ` Jarod Wilson
2009-11-12 0:32 ` Felipe Contreras
2009-11-12 0:43 ` Herbert Xu
2009-10-18 22:54 ` [PATCH 4/7] acpi: processor: fix section mismatch Felipe Contreras
2009-11-04 13:28 ` Jiri Kosina
2009-11-12 0:30 ` Felipe Contreras
2009-10-18 22:54 ` [PATCH 5/7] acpi: fix a bunch of style issues on 'actypes.h' Felipe Contreras
2009-10-19 14:20 ` Jiri Kosina
2009-10-19 14:57 ` Felipe Contreras
2009-10-19 15:03 ` Jiri Kosina
2009-10-19 16:16 ` Felipe Contreras
2009-10-20 5:53 ` Artem Bityutskiy
2009-11-13 20:58 ` Daniel Walker
2009-11-13 21:08 ` Moore, Robert
2009-11-13 21:41 ` Jiri Kosina
2009-11-13 21:48 ` Daniel Walker
2009-10-18 22:54 ` [PATCH 6/7] acpi: fix trivial warning Felipe Contreras
2009-10-19 14:14 ` Jiri Kosina
2009-10-18 22:54 ` [PATCH 7/7] acpi: fix trivial warnings caused by previous commmit Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255906474-25091-2-git-send-email-felipe.contreras@gmail.com \
--to=felipe.contreras@gmail.com \
--cc=gregkh@suse.de \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®