From: Steven Rostedt <rostedt@goodmis.org>
To: wuzhangjin@gmail.com
Cc: Thomas Gleixner <tglx@linutronix.de>,
Nicholas Mc Guire <der.herr@hofr.at>,
Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: ftrace for MIPS
Date: Tue, 20 Oct 2009 12:21:54 -0400 [thread overview]
Message-ID: <1256055714.18347.1608.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1256052667.8149.56.camel@falcon>
On Tue, 2009-10-20 at 23:31 +0800, Wu Zhangjin wrote:
> Just added tracing_stop() and tracing_start() around
That seems a bit heavy handed. I still think writing it in "asm" the way
x86 and powerpc do is the best.
> probe_kernel_read(), it works(not hang again), and i can get the stack
> address of the ra register(return address) now, but failed when trying
> to hijack the return address via writing &return_to_handler in the stack
> address:
>
> I can write hijack some of the addresses, but failed with this error at
> last:
>
> Unable to handle kernel paging request at 0000000000000000, epc =
> 0000000000000000, ra = 000000000000.
hmm, looks like you jumped to "0"
>
> Need to check which registers is missing when saving/restoring for
> _mcount:
>
>
> NESTED(ftrace_graph_caller, PT_SIZE, ra)
> MCOUNT_SAVE_REGS
> PTR_S v0, PT_R2(sp)
>
> MCOUNT_SET_ARGS
> jal prepare_ftrace_return
> nop
>
> /* overwrite the parent as &return_to_handler: v0 -> $1(at) */
> move $1, v0
I'm confused here? I'm not exactly sure what the above is doing. Is $1 a
register (AT)? And how is this register used before calling mcount?
>
> PTR_L v0, PT_R2(sp)
> MCOUNT_RESTORE_REGS
> RETURN_BACK
> END(ftrace_graph_caller)
>
> .align 2
> .globl return_to_handler
> return_to_handler:
> PTR_SUBU sp, PT_SIZE
> PTR_S v0, PT_R2(sp)
BTW, is v0 the only return register? I know x86 can return two different
registers depending on what it returns. What happens if a function
returns a 64 bit value on a 32bit box? Does it use two registers for
that?
-- Steve
>
> jal ftrace_return_to_handler
> nop
>
> /* restore the real parent address: v0 -> ra */
> move ra, v0
>
> PTR_L v0, PT_R2(sp)
> PTR_ADDIU sp, PT_SIZE
>
> jr ra
>
> ...
>
> .macro MCOUNT_SAVE_REGS
> PTR_SUBU sp, PT_SIZE
> PTR_S ra, PT_R31(sp)
> PTR_S AT, PT_R1(sp)
> PTR_S a0, PT_R4(sp)
> PTR_S a1, PT_R5(sp)
> PTR_S a2, PT_R6(sp)
> PTR_S a3, PT_R7(sp)
> #ifdef CONFIG_64BIT
> PTR_S a4, PT_R8(sp)
> PTR_S a5, PT_R9(sp)
> PTR_S a6, PT_R10(sp)
> PTR_S a7, PT_R11(sp)
> #endif
> .endm
>
> .macro MCOUNT_RESTORE_REGS
> PTR_L ra, PT_R31(sp)
> PTR_L AT, PT_R1(sp)
> PTR_L a0, PT_R4(sp)
> PTR_L a1, PT_R5(sp)
> PTR_L a2, PT_R6(sp)
> PTR_L a3, PT_R7(sp)
> #ifdef CONFIG_64BIT
> PTR_L a4, PT_R8(sp)
> PTR_L a5, PT_R9(sp)
> PTR_L a6, PT_R10(sp)
> PTR_L a7, PT_R11(sp)
> #endif
> PTR_ADDIU sp, PT_SIZE
>
> Regards,
> Wu Zhangjin
>
next prev parent reply other threads:[~2009-10-20 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1255995599.17795.15.camel@falcon>
[not found] ` <1255997319.18347.576.camel@gandalf.stny.rr.com>
2009-10-20 15:31 ` Wu Zhangjin
2009-10-20 16:21 ` Steven Rostedt [this message]
2009-10-21 2:33 ` Wu Zhangjin
2009-10-21 2:48 ` Steven Rostedt
2009-10-21 13:14 ` Sergei Shtylyov
2009-10-21 13:20 ` Wu Zhangjin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256055714.18347.1608.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=der.herr@hofr.at \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
--cc=wuzhangjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®