mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: mingo@elte.hu, rostedt@goodmis.org
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>
Subject: [PATCH 2/4] tracing: fix trace_seq_printf return value
Date: Wed, 21 Oct 2009 16:36:39 +0200	[thread overview]
Message-ID: <1256135801-1849-3-git-send-email-jolsa@redhat.com> (raw)
In-Reply-To: <1256135801-1849-1-git-send-email-jolsa@redhat.com>

I believe we want to return the number of written characters,
instead of the available buffer length.

wbr,
jirka

Signed-off-by: Jiri Olsa <jolsa@redhat.com>
---
 kernel/trace/trace_output.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
index ed17565..e871125 100644
--- a/kernel/trace/trace_output.c
+++ b/kernel/trace/trace_output.c
@@ -95,7 +95,7 @@ trace_seq_printf(struct trace_seq *s, const char *fmt, ...)
 
 	s->len += ret;
 
-	return len;
+	return ret;
 }
 EXPORT_SYMBOL_GPL(trace_seq_printf);
 
-- 
1.6.2.5


  parent reply	other threads:[~2009-10-21 14:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-21 14:36 [PATCH 0/4] tracing: couple of minor fixies Jiri Olsa
2009-10-21 14:36 ` [PATCH 1/4] tracing: updating *ppos instead of filp->f_pos Jiri Olsa
2009-10-21 14:36 ` Jiri Olsa [this message]
2009-10-21 16:20   ` [PATCH 2/4] tracing: fix trace_seq_printf return value Steven Rostedt
2009-10-21 22:02     ` Jiri Olsa
2009-10-21 22:14       ` Steven Rostedt
2009-10-22 12:09         ` Jiri Olsa
2009-10-22 12:51           ` Steven Rostedt
2009-10-21 14:36 ` [PATCH 3/4] tracing: comment typo and documentation example fix Jiri Olsa
2009-10-21 14:36 ` [PATCH 4/4] tracing: removing cpu arg from rb_time_stamp function Jiri Olsa
2009-10-21 16:24   ` Steven Rostedt
2009-10-21 16:25 ` [PATCH 0/4] tracing: couple of minor fixies Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1256135801-1849-3-git-send-email-jolsa@redhat.com \
    --to=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®