From: Steven Rostedt <rostedt@goodmis.org>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] [GIT PULL] tracing: allow to change permissions for text with dynamic ftrace enabled
Date: Tue, 27 Oct 2009 19:31:25 -0400 [thread overview]
Message-ID: <1256686285.26028.487.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1256685826.15873.41.camel@sbs-t61.sc.intel.com>
On Tue, 2009-10-27 at 15:23 -0800, Suresh Siddha wrote:
> >
> > I'll test it out, and if it does work, you can write up a formal patch
> > and remove the !define that I added.
>
> I just saw one more place calling do_ftrace_mod_code(). So moved this
> check inside the do_ftrace_mod_code(). Does this cover all the cases?
> Thanks.
For ftrace, probably. But I just realized this may have other
consequences. The CPA_DEBUG tests setting a bit in the page table at
random locations. The code you added makes any change to kernel text
page attributes remove the RW bit. On boot up, it is considered that
kernel text is writable.
Perhaps you need to add a check in your if statement to only prevent
that bit when kernel_set_to_readonly is not true.
-- Steve
next prev parent reply other threads:[~2009-10-27 23:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 17:53 Steven Rostedt
2009-10-27 18:11 ` Ingo Molnar
2009-10-27 19:20 ` Suresh Siddha
2009-10-27 18:33 ` Steven Rostedt
2009-10-27 22:26 ` Suresh Siddha
2009-10-27 21:35 ` Steven Rostedt
2009-10-27 23:23 ` Suresh Siddha
2009-10-27 23:31 ` Steven Rostedt [this message]
2009-10-28 19:56 ` Suresh Siddha
2009-10-28 20:15 ` Steven Rostedt
2009-10-28 22:07 ` Suresh Siddha
2009-10-29 1:20 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256686285.26028.487.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®