From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757128AbZJ1Brp (ORCPT ); Tue, 27 Oct 2009 21:47:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756867AbZJ1Bro (ORCPT ); Tue, 27 Oct 2009 21:47:44 -0400 Received: from mail1.radix.net ([207.192.128.31]:56064 "EHLO mail1.radix.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756655AbZJ1Brn (ORCPT ); Tue, 27 Oct 2009 21:47:43 -0400 Subject: Re: [PATCH 0/7] kfifo: new API v0.6 From: Andy Walls To: Stefani Seibold Cc: Andi Kleen , linux-kernel , Andrew Morton , Arnd Bergmann , Amerigo Wang , Joe Perches , linux-media@vger.kernel.org, Mauro Carvalho Chehab Content-Type: text/plain Date: Tue, 27 Oct 2009 21:49:31 -0400 Message-Id: <1256694571.3131.26.camel@palomino.walls.org> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-2.fc10) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > One thing is that the new API is not compatible with the old one. I > had a look at the current user of the old kfifo API and it is was easy > to adapt it to the new API. These are the files which currently use > the kfifo API: > > drivers/char/nozomi.c > drivers/char/sonypi.c > drivers/infiniband/hw/cxgb3/cxio_resource.c > drivers/media/video/meye.c > drivers/net/wireless/libertas/main.c > drivers/platform/x86/fujitsu-laptop.c > drivers/platform/x86/sony-laptop.c > drivers/scsi/libiscsi.c > drivers/scsi/libiscsi_tcp.c > drivers/scsi/libsrp.c > drivers/usb/host/fhci.h > net/dccp/probe.c > drivers/usb/serial/usb-serial.c > drivers/usb/serial/generic.c Here's a V4L-DVB cx23885 module change, that is on its way upstream, that uses kfifo as is: http://linuxtv.org/hg/v4l-dvb/rev/a2d8d3d88c6d Do you really have to break the old API? Regards, Andy