From: Yong Zhang <yong.zhang0@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>, Yinghai Lu <yinghai@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH 3/3] genirq: remove strange local_irq_disable()
Date: Wed, 4 Nov 2009 21:20:41 +0800 [thread overview]
Message-ID: <1257340841-3739-3-git-send-email-yong.zhang0@gmail.com> (raw)
In-Reply-To: <1257340841-3739-2-git-send-email-yong.zhang0@gmail.com>
local_irq_disable() called in try_one_irq looks very odd and maybe
lead misunderstand.
Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
---
kernel/irq/spurious.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c
index 114e704..430eb9a 100644
--- a/kernel/irq/spurious.c
+++ b/kernel/irq/spurious.c
@@ -54,7 +54,7 @@ static int try_one_irq(int irq, struct irq_desc *desc)
}
action = action->next;
}
- local_irq_disable();
+
/* Now clean up the flags */
spin_lock(&desc->lock);
action = desc->action;
--
1.6.3.3
prev parent reply other threads:[~2009-11-04 13:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 13:20 [PATCH 1/3] genirq: omit validate of desc->chip->shutdown Yong Zhang
2009-11-04 13:20 ` [PATCH 2/3] genirq: set irq thread affinity when doing __setup_irq Yong Zhang
2009-11-04 13:20 ` Yong Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257340841-3739-3-git-send-email-yong.zhang0@gmail.com \
--to=yong.zhang0@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®