From: Wu Zhangjin <wuzhangjin@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ralf Baechle <ralf@linux-mips.org>,
Nicholas Mc Guire <der.herr@hofr.at>,
Richard Sandiford <rdsandiford@googlemail.com>,
David Daney <ddaney@caviumnetworks.com>,
Adam Nemet <anemet@caviumnetworks.com>,
Patrik Kluba <kpajko79@gmail.com>
Subject: Re: [PATCH -v5 08/11] tracing: not trace mips_timecounter_init() in MIPS
Date: Mon, 09 Nov 2009 22:35:20 +0800 [thread overview]
Message-ID: <1257777320.3451.132.camel@falcon.domain.org> (raw)
In-Reply-To: <1257771288.2845.11.camel@frodo>
Hi,
On Mon, 2009-11-09 at 07:54 -0500, Steven Rostedt wrote:
[...]
>
> Just do it in the Makefile. We can add __arch_notrace, and then in the
> Makefile define it with the arch.
>
> ifeq ($(ARCH), MIPS)
> CFLAGS_foo.o = -D__arch_notrace=notrace
> endif
>
> And we can simply define __arch_notrace in a header:
>
> #ifndef __arch_notrace
> # define __arch_notrace
> #endif
>
> I much rather uglify the Makefile than the code.
>
Seems can not totally avoid the problem mentioned by Frederic, that is
if there are two many functions in the file, and different platforms
care about different functions ;)
what about Frederic's __time, just replace that __arch_notrace by
__time_notrace, and only consider the time relative functions currently?
Seems this will really make the stuff simpler.
Regards,
Wu Zhangjin
next prev parent reply other threads:[~2009-11-09 14:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-25 15:16 [PATCH -v5 00/11] ftrace for MIPS Wu Zhangjin
[not found] ` <cover.1256483735.git.wuzhangjin@gmail.com>
2009-10-25 15:16 ` [PATCH -v5 01/11] tracing: convert trace_clock_local() as weak function Wu Zhangjin
2009-10-25 15:16 ` [PATCH -v5 02/11] MIPS: add mips_timecounter_read() to get high precision timestamp Wu Zhangjin
2009-10-26 14:01 ` Steven Rostedt
2009-10-26 14:25 ` Wu Zhangjin
2009-10-26 14:34 ` Steven Rostedt
2009-10-26 14:42 ` Wu Zhangjin
2009-10-25 15:16 ` [PATCH -v5 03/11] tracing: add MIPS specific trace_clock_local() Wu Zhangjin
2009-10-25 15:16 ` [PATCH -v5 04/11] tracing: add static function tracer support for MIPS Wu Zhangjin
2009-10-25 15:16 ` [PATCH -v5 05/11] tracing: enable HAVE_FUNCTION_TRACE_MCOUNT_TEST " Wu Zhangjin
2009-10-25 15:16 ` [PATCH -v5 06/11] tracing: add an endian argument to scripts/recordmcount.pl Wu Zhangjin
2009-10-25 15:16 ` [PATCH -v5 07/11] tracing: add dynamic function tracer support for MIPS Wu Zhangjin
2009-10-25 15:16 ` [PATCH -v5 08/11] tracing: not trace mips_timecounter_init() in MIPS Wu Zhangjin
2009-10-26 0:27 ` Frederic Weisbecker
2009-10-26 9:42 ` Wu Zhangjin
2009-11-02 21:43 ` Frederic Weisbecker
2009-11-03 1:34 ` Wu Zhangjin
2009-11-09 4:31 ` Wu Zhangjin
2009-11-09 11:53 ` Frederic Weisbecker
2009-11-09 12:08 ` Wu Zhangjin
2009-11-09 12:54 ` Steven Rostedt
2009-11-09 14:35 ` Wu Zhangjin [this message]
2009-10-25 15:17 ` [PATCH -v5 09/11] tracing: add IRQENTRY_EXIT for MIPS Wu Zhangjin
2009-10-26 0:36 ` Frederic Weisbecker
2009-10-26 7:26 ` Wu Zhangjin
2009-10-27 17:39 ` Frederic Weisbecker
2009-10-27 17:46 ` Frederic Weisbecker
2009-10-25 15:17 ` [PATCH -v5 10/11] tracing: add function graph tracer support " Wu Zhangjin
2009-10-26 15:13 ` Steven Rostedt
2009-10-26 16:11 ` Wu Zhangjin
2009-10-26 16:32 ` Steven Rostedt
2009-10-26 16:57 ` Wu Zhangjin
2009-10-26 17:11 ` Steven Rostedt
2009-10-25 15:17 ` [PATCH -v5 11/11] tracing: add dynamic function graph tracer " Wu Zhangjin
2009-10-26 1:13 ` [PATCH -v5 10/11] tracing: add function graph tracer support " Wu Zhangjin
2009-10-26 0:42 ` [PATCH -v5 00/11] ftrace " Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257777320.3451.132.camel@falcon.domain.org \
--to=wuzhangjin@gmail.com \
--cc=anemet@caviumnetworks.com \
--cc=ddaney@caviumnetworks.com \
--cc=der.herr@hofr.at \
--cc=fweisbec@gmail.com \
--cc=kpajko79@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=rdsandiford@googlemail.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®