From: Joe Perches <joe@perches.com>
To: mingo@redhat.com, hpa@zytor.com, paulmck@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@elte.hu
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:core/rcu] rcu: Remove inline from forward-referenced functions
Date: Tue, 10 Nov 2009 14:38:30 -0800 [thread overview]
Message-ID: <1257892710.25443.9.camel@Joe-Laptop.home> (raw)
In-Reply-To: <tip-dbe01350fa8ce0c11948ab7d6be71a4d901be151@git.kernel.org>
On Tue, 2009-11-10 at 22:27 +0000, tip-bot for Paul E. McKenney wrote:
> rcu: Remove inline from forward-referenced functions
> diff --git a/kernel/rcutree_plugin.h b/kernel/rcutree_plugin.h
> index ef2a58c..c03edf7 100644
> --- a/kernel/rcutree_plugin.h
> +++ b/kernel/rcutree_plugin.h
> @@ -33,7 +33,7 @@ DEFINE_PER_CPU(struct rcu_data, rcu_preempt_data);
> /*
> * Tell them what RCU they are running.
> */
> -static inline void rcu_bootup_announce(void)
> +static void rcu_bootup_announce(void)
> {
> printk(KERN_INFO
> "Experimental preemptable hierarchical RCU implementation.\n");
> @@ -481,7 +481,7 @@ void exit_rcu(void)
> /*
> * Tell them what RCU they are running.
> */
> -static inline void rcu_bootup_announce(void)
> +static void rcu_bootup_announce(void)
> {
> printk(KERN_INFO "Hierarchical RCU implementation.\n");
> }
non-inline functions in .h files probably aren't a good idea.
next prev parent reply other threads:[~2009-11-10 22:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 21:36 [PATCH tip/core/rcu 0/4] rcu inline, expedited, ->completed cleanups Paul E. McKenney
2009-11-10 21:37 ` [PATCH tip/core/rcu 1/4] rcu: remove inline from forward-referenced functions Paul E. McKenney
2009-11-10 22:27 ` [tip:core/rcu] rcu: Remove " tip-bot for Paul E. McKenney
2009-11-10 22:38 ` Joe Perches [this message]
2009-11-10 22:59 ` Paul E. McKenney
2009-11-10 23:06 ` Joe Perches
2009-11-10 23:41 ` Paul E. McKenney
2009-11-11 1:03 ` Joe Perches
2009-11-11 1:42 ` Paul E. McKenney
2009-11-11 3:28 ` Joe Perches
2009-11-11 4:50 ` Paul E. McKenney
2009-11-11 5:41 ` Paul E. McKenney
2009-11-11 7:02 ` Ingo Molnar
2009-11-11 19:47 ` Paul E. McKenney
2009-11-10 23:03 ` [PATCH tip/core/rcu 1/4] rcu: remove " Josh Triplett
2009-11-10 21:37 ` [PATCH tip/core/rcu 2/4] rcu: enable synchronize_sched_expedited() fastpath Paul E. McKenney
2009-11-10 22:27 ` [tip:core/rcu] rcu: Enable " tip-bot for Paul E. McKenney
2009-11-10 21:37 ` [PATCH tip/core/rcu 3/4] rcu: rename dynticks_completed to completed_fqs Paul E. McKenney
2009-11-10 22:28 ` [tip:core/rcu] rcu: Rename " tip-bot for Paul E. McKenney
2009-11-10 21:37 ` [PATCH tip/core/rcu 4/4] rcu: simplify association of quiescent states with grace periods Paul E. McKenney
2009-11-10 22:28 ` [tip:core/rcu] rcu: Simplify " tip-bot for Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257892710.25443.9.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®