From: David Woodhouse <dwmw2@infradead.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
eric.dumazet@gmail.com
Subject: Re: [PATCH] net/atm: move all compat_ioctl handling to atm/ioctl.c
Date: Wed, 11 Nov 2009 13:34:50 +0000 [thread overview]
Message-ID: <1257946490.25961.1396.camel@macbook.infradead.org> (raw)
In-Reply-To: <200911111430.44361.arnd@arndb.de>
On Wed, 2009-11-11 at 14:30 +0100, Arnd Bergmann wrote:
>
> +struct atmif_sioc32 {
> + compat_int_t number;
> + compat_int_t length;
> + compat_caddr_t arg;
> +};
> +
> +struct atm_iobuf32 {
> + compat_int_t length;
> + compat_caddr_t buffer;
> +};
We already have compat_atmif_sioc and compat_atm_iobuf structures
defined -- do those need to be duplicated?
Other than that, it looks sane. I wish I'd noticed that we already had
half a COMPAT implementation when I added the new bits. Thanks.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2009-11-11 13:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 14:00 [PATCH, WTF] atm: " Arnd Bergmann
2009-11-11 4:41 ` David Miller
2009-11-11 13:30 ` [PATCH] net/atm: " Arnd Bergmann
2009-11-11 13:34 ` David Woodhouse [this message]
2009-11-11 13:45 ` [PATCH v3] " Arnd Bergmann
2009-11-12 3:56 ` David Miller
2009-11-11 13:39 ` [PATCH] net/compat: fix dev_ifsioc emulation corner cases Arnd Bergmann
2009-11-12 3:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257946490.25961.1396.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®