From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754729AbZKLDjX (ORCPT ); Wed, 11 Nov 2009 22:39:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752989AbZKLDjW (ORCPT ); Wed, 11 Nov 2009 22:39:22 -0500 Received: from mga09.intel.com ([134.134.136.24]:41729 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752464AbZKLDjV (ORCPT ); Wed, 11 Nov 2009 22:39:21 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.44,726,1249282800"; d="scan'208";a="568768200" Subject: Re: [PATCH] x86: make sure wakeup code is below 1M -v2 From: ykzhao To: Yinghai Lu Cc: "Rafael J. Wysocki" , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Len Brown , "linux-kernel@vger.kernel.org" , ACPI Devel Maling List , pm list In-Reply-To: <4AFB7D21.6050004@kernel.org> References: <4AF7D820.5040503@kernel.org> <200911091315.13151.rjw@sisk.pl> <4AFA210B.3020207@kernel.org> <1257930767.31183.113.camel@localhost.localdomain> <4AFB0B02.4050306@kernel.org> <1257988632.31183.134.camel@localhost.localdomain> <4AFB7D21.6050004@kernel.org> Content-Type: text/plain Organization: Intel Open Source Technology Center Date: Thu, 12 Nov 2009 11:37:52 +0800 Message-Id: <1257997072.3888.4.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 (2.22.1-2.fc9) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2009-11-12 at 11:12 +0800, Yinghai Lu wrote: > ykzhao wrote: > > On Thu, 2009-11-12 at 03:05 +0800, Yinghai Lu wrote: > >> ykzhao wrote: > >>> On Wed, 2009-11-11 at 10:27 +0800, Yinghai Lu wrote: > >>>> try to find_e820_area/reserve_early, and call acpi_reserve_memory early > >>>> > >>>> to get area is below 1M > >>>> > >>>> -v2: change function name to acpi_reserve_wakeup_memory according to Rafael > >>> It seems that the function of find_e820_area is called in several > >>> places. > >>> >Initmem_init: bootmap = find_e820_area(0, end_pfn< >>> bootmap_size, PAGE_SIZE); > >>> > >>> If we also call it in the acpi_reserve_wakeup_memory, do we get the same > >>> base address as that obtained in initmem_init? > >> no. find_e820_area will check the reserve res array that could be updated by reserve_early. > > It will check the reserved region array when calling the function of > > find_e820_area. > > But it seems that the array is not updated when the find_e820_area is > > called in the function of initmem_init. > > right after that will use reserve_bootmem for those range in initmem_init. Yes. The reserve_bootmem is called for the range in initmem_init. But the reserved_early array is not updated. > > also we could reserve_early there and let bootmem conversion to do that for us. > > but for numa there is some chance to use other node bootmem to for that bootdata and bitmap. > so make it simple just use reserve_bootmem there. > > YH