From: Mike Galbraith <efault@gmx.de>
To: Ingo Molnar <mingo@elte.hu>, Dave Jones <davej@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [patch] cpu_early_init() breakage
Date: Sat, 14 Nov 2009 13:43:22 +0100 [thread overview]
Message-ID: <1258202602.6380.3.camel@marge.simson.net> (raw)
0388423 typo caused loss of vendor data even with CONFIG_PROCESSOR_SELECT.
[ 0.000000] CPU: vendor_id 'GenuineIntel' unknown, using generic init.
[ 0.000000] CPU: Your system may be unstable.
[ 0.044003] MCE: unknown CPU type - not enabling MCE support.
...
[ 0.437241] Brought up 4 CPUs
[ 0.440002] Total of 4 processors activated (19139.97 BogoMIPS).
[ 0.448021] CPU0 attaching sched-domain:
[ 0.448024] domain 0: span 0-3 level MC
[ 0.448026] groups: 0 1 2 3
[ 0.448031] CPU1 attaching sched-domain:
[ 0.448033] domain 0: span 0-3 level MC
[ 0.448035] groups: 1 2 3 0
[ 0.448039] CPU2 attaching sched-domain:
[ 0.448041] domain 0: span 0-3 level MC
[ 0.448043] groups: 2 3 0 1
[ 0.448047] CPU3 attaching sched-domain:
[ 0.448048] domain 0: span 0-3 level MC
[ 0.448050] groups: 3 0 1 2
x86: Fix typo in 0388423 "Minimise printk spew from per-vendor init code"
Signed-off-by: Mike Galbraith <efault@gmx.de>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Dave Jones <davej@redhat.com>
LKML-Reference: <new-submission>
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index 973080b..3c7f7fd 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -651,11 +651,12 @@ static void __init early_identify_cpu(struct cpuinfo_x86 *c)
void __init early_cpu_init(void)
{
-#ifdef PROCESSOR_SELECT
const struct cpu_dev *const *cdev;
int count = 0;
+#ifdef CONFIG_PROCESSOR_SELECT
printk(KERN_INFO "KERNEL supported cpus:\n");
+#endif
for (cdev = __x86_cpu_dev_start; cdev < __x86_cpu_dev_end; cdev++) {
const struct cpu_dev *cpudev = *cdev;
unsigned int j;
@@ -668,11 +669,12 @@ void __init early_cpu_init(void)
for (j = 0; j < 2; j++) {
if (!cpudev->c_ident[j])
continue;
+#ifdef CONFIG_PROCESSOR_SELECT
printk(KERN_INFO " %s %s\n", cpudev->c_vendor,
cpudev->c_ident[j]);
+#endif
}
}
-#endif
early_identify_cpu(&boot_cpu_data);
}
next reply other threads:[~2009-11-14 12:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-14 12:43 Mike Galbraith [this message]
2009-11-14 13:06 ` Mike Galbraith
2009-11-15 8:05 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258202602.6380.3.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®