From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F94831B828 for ; Fri, 13 Feb 2026 10:56:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770980210; cv=none; b=S15c8/jtnQxk39PEBp5LNm1+wXO82kWPgic5X+umkFsPVn5aRWiIfKG3qc/4vMEpVqhqNFMgMwCfcIpAkohksnkylquJQ/gOnxtQzcoL3aEDy+7H0qWqC/wa9q++FG4yTHeWs76YQHehBgj7xA7rUlFVmBrP2iHHa/RoJGR43Yk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770980210; c=relaxed/simple; bh=Aw8E39mtCHRNjN5qaMEUVcqXCOU0w1dL4yvuWv18EHM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GBLM69TAq0t36qyy4U9kptD1LuulgkIad18AWjcpfBF6k83jT2wymIu6j0mZVsVTkDKRQN50zfAZEhKPVaJTNwfOFlyOkD1VA6nq2ayWgYnt6d4bigaZGn1h5sQGeqBBEjeXKbgzR+uFPGraboEAiJ8fKdSHOHIukn6wCkt/Qp0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BkMrh4Qz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cY8s9gx1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BkMrh4Qz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cY8s9gx1" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61D83STW652726 for ; Fri, 13 Feb 2026 10:56:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GiyB6807wBrlpme0SqbesGsmjlyBbej8e4mtB4Wk21k=; b=BkMrh4QzM+3T3Y4s oGf7HFnMSQ3lhSyedS41Ay/zqwXvLE0nvm0ca5X5bwbTZrbExubRABxRhOaF5658 3g85N1jZqep3PW/AcyhHf8MqmPBmwB6CW/UiS/som1SK2fJBytUTKOjqIZElfC9i ODc/x9WRO8HKjcj40C4eBO47Qa30TDk2Od/ZS0EXAclaGKf4g1dlv9wJn4azwDrh 6R9MrE4RkJpCdeU7F2UaPOD252LZygx5i4ZSykjQAx7Mum/RjYbkLH9/VowWmlvM Qmyk3sQsoAfY/DIHjhRxwzAQQ/YVspYbrdbi0XNQJmve8GnZdXlaZl4NWSiju4GO +6JzKQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c9gbbm43e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Feb 2026 10:56:48 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2aad5fc5b2fso11723185ad.1 for ; Fri, 13 Feb 2026 02:56:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770980208; x=1771585008; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GiyB6807wBrlpme0SqbesGsmjlyBbej8e4mtB4Wk21k=; b=cY8s9gx1xmBFLaLYH5jW0HCH5Y0iWyi2PxQEeXz5xqTPdpnt1bAhcgWjWRzq8DTpVt seVmG7XmimCrl6wHYr5K5aZNhA1UEQPPqOLMjSDhKrh2PXymEMdv7o6IA6v9nxYMrZU+ v9UqiLS0GfdMJPipmOsGD3gRr1MeXMZ9wxNEJqiYZp5IPMQr7b0vLXaclDF/C3dGkdpl C6GNDuoi7u2LPGodHx1b9nlsAaUSLcf1m55CFc3LQkHbaLhHRa+uDWJuO2QMviO5kiY8 LcVhJlHjqX4K/DDEjBLBrZO8o4mW9dBqlqi2YOt8IdneLEp72EwQd3JprSA8dzNsmzdY h4nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770980208; x=1771585008; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GiyB6807wBrlpme0SqbesGsmjlyBbej8e4mtB4Wk21k=; b=WxwQxWpT1aUB9GpylwltnKa/Y1+J1USF+ifhrneNKzZEJW9RdL0Ov6c2+XM5vln8Fm 8i144DuN+29k/XL1sxjL9cBN9IJTxbSSPeR7ggWWYmwyWTgEbnMESq3pWuIjPdrU7tUI c99TDWDBfSYv7iB2f/n4yYcO1KqlfqAA1oNpr/3y7oTL9Ci/fD+EgoPQUwznmF48cE9M LpkgOcprVSrdoy++zhiEmo1k6wCkLwkUeHstGFdEAbpgWJBRjJb1G7JGuADhgX9sn/fJ jumZ80Zl17IyDhcNq3SfjB9Dxuet56DqmbjH5ti3WWmnjUqkIJS/A2AdBd0bNK9hmgrg L3JQ== X-Forwarded-Encrypted: i=1; AJvYcCUzst8w75OtIgPNGnD4qQQ1Xva01vSVVC6HajKSb2T8mBSL06S44p7m05wPH3uZbS29sPVzs0FpwyHNIxY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywvnzzmc13nYYLQgTSlGPTXcOGbPxZKQV1f825SNsGUlr+rJJ+0 ifxTxwA/AjIDWLua77QawQL5YZXZBQjX2JNqAtPuPM0MuOUyS3zVKp2oPd7+KXy1ol8qJrGOTP+ 8pwpnAsRtZ2F0ENxFKYtwZ7/jCTBCLxxIg46qKJ6K5iKHfKq2I5DXc/RKEQVrbUrTDV8= X-Gm-Gg: AZuq6aIQwh8FTqVMZD56K9YGprUSCWNgUfOCmSBwTYK3a+8SvXH9UviI1p/9Hgamdm9 Np3ATqIysFf+Q1giIa4Qk01eYujXHAKMoecAvDie9eEdw9KSMabkBHV+YUWdyqnOx2KPdAEL+pu KQnY8PiUnO3sviMHiLqDwXlvpKmiRH2w59NJ5C6rlwwC57cPwFJFe7NHD4kvzCT/4id73uoCWqX flN4wpXseTd41qw70DUzTyOeB8hTUqQ0Bpv1YRkAa1x5d/3ESX6U5+xUMQU6vEAD5WJft08KwPM ag8kqSkzHiqJ8xA3WmbZ6pC1R5IED1nzAEm+KU6RljzkkVbjZo3grcol8rfy1DJG/8MrBSsvy9o O3juyMrdVNh0k4ohbxJELM6G/Tv0ie0NNBOFVrKVixrLT+pbS+oY= X-Received: by 2002:a17:903:298d:b0:2aa:d333:ce84 with SMTP id d9443c01a7336-2ab5051a197mr15933095ad.11.1770980207979; Fri, 13 Feb 2026 02:56:47 -0800 (PST) X-Received: by 2002:a17:903:298d:b0:2aa:d333:ce84 with SMTP id d9443c01a7336-2ab5051a197mr15932795ad.11.1770980207488; Fri, 13 Feb 2026 02:56:47 -0800 (PST) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ab29966633sm77807725ad.58.2026.02.13.02.56.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Feb 2026 02:56:47 -0800 (PST) Message-ID: <12582709-7dca-4f1a-99ab-8a21cd70f1c5@oss.qualcomm.com> Date: Fri, 13 Feb 2026 16:26:42 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] arm64: defconfig: Enable QCOMTEE module for QTEE-enabled Qualcomm SoCs To: Krzysztof Kozlowski , Kuldeep Singh , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , Sumit Garg , Jens Wiklander Cc: Amirreza Zarrabi , Arnd Bergmann , Geert Uytterhoeven , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org References: <20260114-qcom_qcomtee_defconfig-v4-1-ec676311171f@oss.qualcomm.com> Content-Language: en-US From: Harshal Dev In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEzMDA4MyBTYWx0ZWRfX9K8gEyhPGVh2 0ZwE6qwy5rJ587o7h3Ys8LLx1f5lqQCj/jN7cElTEkOT9G3grQ3pn3PoRanBKuQdY0Jbn5zLKMY rrtPaZvlXp99tyb5nTCsq+RTU5KceaYwoHPsWmJYA9klmak22aOofrJn+mrdNt0cSJnXyIYOu3n WKVPZnhf25FVyhKHhDyOwHdYeUS2cFziMchtK0RELwR9mCFOFaaZ/coyC3l7tW+cDghnRQx+b/b v0oS3ygASLsWGIeB1MWgWljLCZtBSC3UUvUnXXMsvlaWAhUZqwTOa3FcQRh6vYRBg+65evnrs3W RccwVUkqZG87Fn77LEi9JeXnvuvOPuYUzptoYyJ0ww2nr0/J6k1rlzGOQJjGV+FpSOEP3uRamEh mJsFVDSCpyd9TqnLwy4bvvtaZe/aQINjX633qFKK8DkExbZ071tSF6MkElYMnjuRgxbu+1vnx5f ZLILINp5209bX4ydEeQ== X-Authority-Analysis: v=2.4 cv=a849NESF c=1 sm=1 tr=0 ts=698f0370 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=P-IC7800AAAA:8 a=NEAV23lmAAAA:8 a=EUspDBNiAAAA:8 a=8PXTMM9NJao95hONEFkA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-GUID: CLczx0h9lVGsyAhG_9AhNET97JgWAjcp X-Proofpoint-ORIG-GUID: CLczx0h9lVGsyAhG_9AhNET97JgWAjcp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-13_01,2026-02-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 malwarescore=0 phishscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 clxscore=1015 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602130083 Hi Krzysztof, On 2/13/2026 3:56 PM, Krzysztof Kozlowski wrote: > On 13/02/2026 11:24, Kuldeep Singh wrote: >> >> >> On 1/14/2026 1:49 PM, Harshal Dev via OP-TEE wrote: >>> All Qualcomm SoCs starting from SM8650 provide access to the Qualcomm >>> Trusted Execution Environment (QTEE) through the SMCInvoke interface, >>> implemented by the QCOMTEE driver. QTEE runs in the Secure World domain >>> on ARM64 CPUs and exposes secure services to Linux running in the Normal >>> World domain. >>> >>> This change enables the QCOMTEE driver as a module to support >>> communication with QTEE. >>> >>> QCOMTEE has been tested on a Qualcomm RB3Gen2 board by loading and >>> executing a Trusted Application via tests hosted at >>> github.com/qualcomm/minkipc. >>> >>> Signed-off-by: Harshal Dev >> >> Tested on rb3gen2 device and able to see driver load successfully. > > What exactly did you test? That a module can be built? > >> >> root@qcom-armv8a:~# lsmod | grep qcomtee >> qcomtee 32768 0 > > Sorry, but that's basic of kbuild and module system. > > >> root@qcom-armv8a:~# rmmod qcomtee >> root@qcom-armv8a:~# insmod > > Not a defconfig testing. > >> /lib/modules/6.18.0-next-20251202-00002-ga8c3ce157925 >> -dirty/kernel/drivers/tee/qcomtee/qcomtee.ko >> [ 164.464598] qcomtee: QTEE version 5.2.0 >> root@qcom-armv8a:~# ls /dev/tee0 >> /dev/tee0 >> root@qcom-armv8a:~# >> >> With that, >> Reviewed-by: Kuldeep Singh >> Tested-by: Kuldeep Singh > > You cannot test a defconfig. I think these logs didn't convey the full picture. QCOMTEE driver holds references to objects and callback requests received from QTEE during invocations. Being able to remove the driver without the the user thread being stuck helps test that the close_context() callback which calls into QTEE to release all pending objects and callback requests held in qcomtee_context_data is correctly implemented by the driver. https://elixir.bootlin.com/linux/v6.19-rc5/source/drivers/tee/qcomtee/call.c#L600 Before this patch, I believe the driver was being compiled with CONFIG_QCOMTEE=y so the qcomtee_remove() function path wasn't being exercised. Perhaps we can provide more logs (rmmod attempted after running direct invocation tests) to convey that this is what we are testing here on the RB3Gen2 board. Thanks, Harshal > > > > Best regards, > Krzysztof