mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>
Subject: [RFC 0/4] compat-ioctl.c diet
Date: Sun, 15 Nov 2009 16:04:06 +0000	[thread overview]
Message-ID: <1258301050-26900-1-git-send-email-arnd@arndb.de> (raw)

I've spent some time on making the compat ioctl code significantly smaller.
Removing the tty and socket level ioctl handling from common code
in linux-next helps a bit, but mostly just moves code to other places
but does not save much in an allyesconfig.


This is the output of /usr/bin/size on the fs/compat_ioctl.o
file in different versions:

2.6.32-rc7:
   text    data     bss     dec     hex filename
  13335   17792    2080   33207    81b7 obj/fs/compat_ioctl.o
linux-next:
   8877   14696    2080   25653    6435 obj/fs/compat_ioctl.o
Simplifying the remaining code (this series):
   7572    2144       4    9720    25f8 obj/fs/compat_ioctl.o
Moving more handlers directly into driver (future series):
   4817    1740       4    6561    19a1 obj/fs/compat_ioctl.o

There are a few dependencies on code in other trees, so this
series doesn't currently apply cleanly anywhere except my
own tree.

The final series of patches that I'll post separately
depends on this one as well and touches most of the drivers
that currently require a conversion function in fs/compat_ioctl.c
that no other driver uses. Moving those conversions into
the drivers simplifies the common code and keeps the
native and compat versions closer.

	Arnd <><

---

Arnd Bergmann (4):
  compat_ioctl: inline all conversion handlers
  compat_ioctl: simplify calling of handlers
  compat_ioctl: simplify lookup table
  compat_ioctl: pass compat pointer directly to handlers

 fs/compat_ioctl.c |  471 +++++++++++++++++++++++++----------------------------
 1 files changed, 220 insertions(+), 251 deletions(-)


             reply	other threads:[~2009-11-15 16:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-15 16:04 Arnd Bergmann [this message]
2009-11-15 16:04 ` [RFC 1/4] compat_ioctl: inline all conversion handlers Arnd Bergmann
2009-11-15 16:04 ` [RFC 2/4] compat_ioctl: simplify calling of handlers Arnd Bergmann
2009-11-15 16:04 ` [RFC 3/4] compat_ioctl: simplify lookup table Arnd Bergmann
2009-11-15 16:04 ` [RFC 4/4] compat_ioctl: pass compat pointer directly to handlers Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258301050-26900-1-git-send-email-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®