From: "Steven J. Magnani" <steve@digidescorp.com>
To: "Américo Wang" <xiyou.wangcong@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] procfs: Use proper units for noMMU statm
Date: Mon, 16 Nov 2009 08:47:33 -0600 [thread overview]
Message-ID: <1258382853.3019.0.camel@iscandar.digidescorp.com> (raw)
In-Reply-To: <20091114044153.GB2416@hack>
On Sat, 2009-11-14 at 12:41 +0800, Américo Wang wrote:
> On Fri, Nov 13, 2009 at 07:52:14PM -0600, steve@digidescorp.com wrote:
> >On no-MMU systems, sizes reported in /proc/n/statm have units of bytes.
> >Per Documentation/filesystems/proc.txt, these values should be in pages.
> >
> > ...
> >
> >+ *data = (mm->start_stack - mm->start_data) >> PAGE_SHIFT;
>
> Are '->start_stack' and '->start_data' already page aligned on NOMMU arch?
>
In looking over binfmt_flat.c (main executable type for noMMU systems),
I don't think there's a guarantee of more than 32- or 64-bit alignment.
Thanks for the suggestion, I'll submit an updated patch.
------------------------------------------------------------------------
Steven J. Magnani "I claim this network for MARS!
www.digidescorp.com Earthling, return my space modulator!"
#include <standard.disclaimer>
next prev parent reply other threads:[~2009-11-16 14:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-14 1:52 steve
2009-11-14 4:41 ` Américo Wang
2009-11-16 14:47 ` Steven J. Magnani [this message]
2009-11-16 14:50 ` [PATCH v2] " steve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258382853.3019.0.camel@iscandar.digidescorp.com \
--to=steve@digidescorp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome